From reviews-return-26859-archive-asf-public=cust-asf.ponee.io@impala.apache.org Tue Jan 9 20:23:47 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E0F11180718 for ; Tue, 9 Jan 2018 20:23:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D763F160C2D; Tue, 9 Jan 2018 19:23:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 28EE8160C17 for ; Tue, 9 Jan 2018 20:23:47 +0100 (CET) Received: (qmail 87462 invoked by uid 500); 9 Jan 2018 19:23:46 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 87450 invoked by uid 99); 9 Jan 2018 19:23:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jan 2018 19:23:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A310F1A015D for ; Tue, 9 Jan 2018 19:23:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 6xODYvBaDyT0 for ; Tue, 9 Jan 2018 19:23:44 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 40E935F36C for ; Tue, 9 Jan 2018 19:23:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id w09JNfBK015751; Tue, 9 Jan 2018 19:23:41 GMT Message-Id: <201801091923.w09JNfBK015751@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 6 Date: Tue, 9 Jan 2018 19:23:40 +0000 From: "Tim Armstrong (Code Review)" To: Vuk Ercegovac , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Lars Volker , Alex Behm X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4993=3A_extend_dictionary_filtering_to_collections=0A?= X-Gerrit-Change-Id: If3a2abcfc3d0f7d18756816659fed77ce12668dd X-Gerrit-Change-Number: 8775 X-Gerrit-ChangeURL: X-Gerrit-Commit: 14fe31df405324d6add3941731cefffd2a2d6bfb In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 9 Jan 2018 19:23:40 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com, marcelk@gmail.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org, vercegovac@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="VKL0iUriaks="; charset=UTF-8 --VKL0iUriaks= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filte= ring to collections =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 6: (6 comments) Took a detailed look at the backend h= ttp://gerrit=2Ecloudera=2Eorg:8080/#/c/8775/6/be/src/exec/hdfs-parquet-scan= ner=2Eh File be/src/exec/hdfs-parquet-scanner=2Eh: http://gerrit=2Eclouder= a=2Eorg:8080/#/c/8775/6/be/src/exec/hdfs-parquet-scanner=2Eh@462 PS6, Line = 462: std::unordered_map> It would make more sense at this point to use a MemPool instead of a = proliferation of ScopedBuffers in dict_filter_tuple_map_ and min_max_tuple_= buffer_ - it's the canonical way to make multiple small allocations that ar= e freed at the same time=2E It would have made sense even before this patch= =2E level_cache_pool_ already has the right lifetime (freed in close) so w= e could just rename that to something more generic that reflects the lifet= ime=2E E=2Eg=2E we call something similar a "perm_pool" elsewhere because i= ts contents have the same lifetime as the owning object=2E http://gerrit= =2Ecloudera=2Eorg:8080/#/c/8775/6/be/src/exec/hdfs-parquet-scanner=2Eh@649 = PS6, Line 649: /// Gets the TupleDescriptor of slot_desc=2E Mention that = 'slot_desc' can belong to the top-level tuple or a tuple nested in a collec= tion? http://gerrit=2Ecloudera=2Eorg:8080/#/c/8775/6/be/src/exec/hdfs-par= quet-scanner=2Ecc File be/src/exec/hdfs-parquet-scanner=2Ecc: http://gerri= t=2Ecloudera=2Eorg:8080/#/c/8775/6/be/src/exec/hdfs-parquet-scanner=2Ecc@a1= 620 PS6, Line 1620: thanks :) http://gerrit=2Ecloudera=2Eorg:8080/#/c/87= 75/6/be/src/exec/hdfs-parquet-scanner=2Ecc@771 PS6, Line 771: if (!col_re= ader->IsCollectionReader()) { nit: I think this would be easier to follow i= f we reversed the branches and removed the negation=2E http://gerrit=2Ecl= oudera=2Eorg:8080/#/c/8775/6/be/src/exec/hdfs-parquet-scanner=2Ecc@815 PS6,= Line 815: for (auto* col_reader : column_readers_) { nit: could fit on o= ne line now http://gerrit=2Ecloudera=2Eorg:8080/#/c/8775/6/be/src/exec/hd= fs-parquet-scanner=2Ecc@1657 PS6, Line 1657: if (column_readers=2Eempty()= ) return Status::OK(); Is the early exit necessary for correctness? Might b= e worth mentioning if it is=2E Otherwise, I don't think it matters for per= formance so my bias is towards leaving it out=2E -- To view, visit http= ://gerrit=2Ecloudera=2Eorg:8080/8775 To unsubscribe, visit http://gerrit=2E= cloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: mas= ter Gerrit-MessageType: comment Gerrit-Change-Id: If3a2abcfc3d0f7d187568166= 59fed77ce12668dd Gerrit-Change-Number: 8775 Gerrit-PatchSet: 6 Gerrit-Owner= : Vuk Ercegovac Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker G= errit-Reviewer: Tim Armstrong Gerrit-Reviewer: = Vuk Ercegovac Gerrit-Comment-Date: Tue, 09 Jan = 2018 19:23:40 +0000 Gerrit-HasComments: Yes --VKL0iUriaks=--