From reviews-return-26821-archive-asf-public=cust-asf.ponee.io@impala.apache.org Mon Jan 8 21:28:13 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id AFE11180607 for ; Mon, 8 Jan 2018 21:28:13 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9FC38160C2C; Mon, 8 Jan 2018 20:28:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E4EF3160C29 for ; Mon, 8 Jan 2018 21:28:12 +0100 (CET) Received: (qmail 49492 invoked by uid 500); 8 Jan 2018 20:28:12 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 49481 invoked by uid 99); 8 Jan 2018 20:28:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 20:28:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 720FBC0DEE for ; Mon, 8 Jan 2018 20:28:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.562 X-Spam-Level: ** X-Spam-Status: No, score=2.562 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_MANYTO=0.2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 7gA7bcS6nOtQ for ; Mon, 8 Jan 2018 20:28:10 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B614B5F3DF for ; Mon, 8 Jan 2018 20:28:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id w08KS7LJ015187; Mon, 8 Jan 2018 20:28:07 GMT Message-Id: <201801082028.w08KS7LJ015187@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Mon, 8 Jan 2018 20:28:07 +0000 From: "Vuk Ercegovac (Code Review)" To: Thomas Tauber-Marshall , Taras Bobrovytsky , Lars Volker , Dimitris Tsirogiannis , Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3526=3A_update_FE_tests_to_pass_on_S3=0A?= X-Gerrit-Change-Id: I4c8221949e76b0a0b9192e6b56c4da5eeae04141 X-Gerrit-Change-Number: 8890 X-Gerrit-ChangeURL: X-Gerrit-Commit: fb0b18f4cabac9cd2f7527202b5c26a2ea538035 In-Reply-To: References: Reply-To: vercegovac@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com, marcelk@gmail.com, tbobrovytsky@cloudera.com, tmarshall@cloudera.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org, dtsirogiannis@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="jgH5d8K0TZY="; charset=UTF-8 --jgH5d8K0TZY= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Dimitris Tsir= ogiannis, Alex Behm, I'd like you to reexamine a change=2E Please visit = http://gerrit=2Ecloudera=2Eorg:8080/8890 to look at the new patch set = (#3)=2E Change subject: IMPALA-3526: update FE tests to pass on S3 =2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E IMPALA-3526: update= FE tests to pass on S3 Plans for some queries/same data may differ when t= he same data is stored on S3 vs=2E HDFS=2E This is due to block size differ= ences used to enumerate range scans on the different file systems=2E As a r= esult, FE tests have been disabled for S3 configurations=2E This has also l= ed to staleness in the tests that were specific to S3=2E Most of the broken= tests are due to staleness, but several are due to true plan differences= =2E This change fixes stale tests and separates out those test queries who= se plans differ across S3 and HDFS=2E Tests: - ran FE tests on S3 Change-= Id: I4c8221949e76b0a0b9192e6b56c4da5eeae04141 --- M fe/src/test/java/org/ap= ache/impala/planner/PlannerTest=2Ejava M fe/src/test/java/org/apache/impala= /planner/S3PlannerTest=2Ejava A testdata/workloads/functional-planner/queri= es/PlannerTest/join-order-hdfs=2Etest A testdata/workloads/functional-plann= er/queries/PlannerTest/join-order-s3=2Etest M testdata/workloads/functional= -planner/queries/PlannerTest/join-order=2Etest M testdata/workloads/functio= nal-planner/queries/PlannerTest/s3=2Etest M testdata/workloads/functional-p= lanner/queries/PlannerTest/tpch-all=2Etest A testdata/workloads/functional-= planner/queries/PlannerTest/tpch-hdfs=2Etest A testdata/workloads/functiona= l-planner/queries/PlannerTest/tpch-s3=2Etest 9 files changed, 2,171 inserti= ons(+), 1,064 deletions(-) git pull ssh://gerrit=2Ecloudera=2Eorg:29418= /Impala-ASF refs/changes/90/8890/3 -- To view, visit http://gerrit=2Ecloud= era=2Eorg:8080/8890 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:80= 80/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Messag= eType: newpatchset Gerrit-Change-Id: I4c8221949e76b0a0b9192e6b56c4da5eeae04= 141 Gerrit-Change-Number: 8890 Gerrit-PatchSet: 3 Gerrit-Owner: Vuk Ercegov= ac Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: T= aras Bobrovytsky Gerrit-Reviewer: Thomas Taub= er-Marshall Gerrit-Reviewer: Vuk Ercegovac --jgH5d8K0TZY=--