From reviews-return-26784-archive-asf-public=cust-asf.ponee.io@impala.apache.org Sat Jan 6 19:26:15 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5CC5418062C for ; Sat, 6 Jan 2018 19:26:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4CC26160C3B; Sat, 6 Jan 2018 18:26:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9E4B6160C19 for ; Sat, 6 Jan 2018 19:26:14 +0100 (CET) Received: (qmail 74411 invoked by uid 500); 6 Jan 2018 18:26:13 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 74400 invoked by uid 99); 6 Jan 2018 18:26:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Jan 2018 18:26:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2E8161806E2 for ; Sat, 6 Jan 2018 18:26:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id S5147N0Y-zdL for ; Sat, 6 Jan 2018 18:26:12 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 2DC345F24A for ; Sat, 6 Jan 2018 18:26:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id w06IQABu023283; Sat, 6 Jan 2018 18:26:10 GMT Message-Id: <201801061826.w06IQABu023283@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Sat, 6 Jan 2018 18:26:10 +0000 From: "Adam Holley (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4323=3A_=22SET_ROW_FORMAT=22_option_added_to_=22ALTER_TABLE=22_command=0A?= X-Gerrit-Change-Id: I96e347463504915a6f33932552e4d1f61e9b1154 X-Gerrit-Change-Number: 8928 X-Gerrit-ChangeURL: X-Gerrit-Commit: c4d4978fc284485453618516216b580053859549 In-Reply-To: References: Reply-To: git@holleyism.com, impala-cr@cloudera.com, marcelk@gmail.com, jbapple-impala@apache.org, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="E83vk5Wj0vs="; charset=UTF-8 --E83vk5Wj0vs= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Adam Holley has uploaded a new patch set (#4)=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option ad= ded to "ALTER TABLE" command =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE= " command Examples of new command: ALTER TABLE t1 SET ROW FORMAT DELIMITED= FIELDS TERMINATED BY '\002'; ALTER TABLE t1 SET ROW FORMAT DELIMITED LINES= TERMINATED BY '\001'; Testing: Added parser tests and unit tests for alte= r statements including partition options=2E Change-Id: I96e347463504915a6f= 33932552e4d1f61e9b1154 --- M common/thrift/JniCatalog=2Ethrift M fe/src/mai= n/cup/sql-parser=2Ecup A fe/src/main/java/org/apache/impala/analysis/AlterT= ableSetRowFormatStmt=2Ejava M fe/src/main/java/org/apache/impala/catalog/Hi= veStorageDescriptorFactory=2Ejava M fe/src/main/java/org/apache/impala/serv= ice/CatalogOpExecutor=2Ejava M fe/src/test/java/org/apache/impala/analysis/= AnalyzeDDLTest=2Ejava M fe/src/test/java/org/apache/impala/analysis/ParserT= est=2Ejava M testdata/workloads/functional-query/queries/QueryTest/alter-ta= ble=2Etest 8 files changed, 260 insertions(+), 6 deletions(-) git pull = ssh://gerrit=2Ecloudera=2Eorg:29418/Impala-ASF refs/changes/28/8928/4 -- T= o view, visit http://gerrit=2Ecloudera=2Eorg:8080/8928 To unsubscribe, visi= t http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF = Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I96= e347463504915a6f33932552e4d1f61e9b1154 Gerrit-Change-Number: 8928 Gerrit-Pa= tchSet: 4 Gerrit-Owner: Adam Holley Gerrit-Reviewer: = Adam Holley Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul --E83vk5Wj0vs=--