Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9215C160C26 for ; Tue, 2 Jan 2018 23:25:45 +0100 (CET) Received: (qmail 81556 invoked by uid 500); 2 Jan 2018 22:25:44 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 81543 invoked by uid 99); 2 Jan 2018 22:25:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2018 22:25:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CE1E8C2A65 for ; Tue, 2 Jan 2018 22:25:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id WYyKvaePh8gY for ; Tue, 2 Jan 2018 22:25:42 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id F30C95FB9E for ; Tue, 2 Jan 2018 22:25:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id w02MPdF8032709; Tue, 2 Jan 2018 22:25:39 GMT Message-Id: <201801022225.w02MPdF8032709@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Tue, 2 Jan 2018 22:25:39 +0000 From: "Impala Public Jenkins (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5557=3A_Disable_rpc_default_keepalive_time_ms=0A?= X-Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775 X-Gerrit-Change-Number: 8910 X-Gerrit-ChangeURL: X-Gerrit-Commit: a550b5b56063eab6dafc2863c4dccd1455db6606 In-Reply-To: References: Reply-To: impala-cr@cloudera.com, kwho@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="DCFFe7DEzqE="; charset=UTF-8 archived-at: Tue, 02 Jan 2018 22:25:46 -0000 --DCFFe7DEzqE= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Impala Public Jenkins has submitted this change and it was merged=2E ( http= ://gerrit=2Ecloudera=2Eorg:8080/8910 ) Change subject: IMPALA-5557: Disabl= e rpc_default_keepalive_time_ms =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E IMPALA-5557: Disable rpc_default_keepalive_time_ms Thi= s change makes sure backend connections with KRPC are always kept alive by = disabling the idle connection detection logic=2E Idle connections all tend= to be closed and re-opened around the same time, which may easily lead to = negotiation timeouts=2E Until KUDU-279 is fixed, closing idle connections i= s also racy and leads to query failures=2E This disablement was validated = with Kudu's rpc-test=2E Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf07= 75 Reviewed-on: http://gerrit=2Ecloudera=2Eorg:8080/8910 Reviewed-by: Micha= el Ho Reviewed-by: Sailesh Mukil Tested-by: Impala Public Jenkins --- M be/src/rpc/rpc-mgr=2Ecc 1 file = changed, 8 insertions(+), 0 deletions(-) Approvals: Michael Ho: Looks go= od to me, but someone else must approve Sailesh Mukil: Looks good to me, = approved Impala Public Jenkins: Verified -- To view, visit http://gerri= t=2Ecloudera=2Eorg:8080/8910 To unsubscribe, visit http://gerrit=2Ecloudera= =2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerr= it-MessageType: merged Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec7= 9cf0775 Gerrit-Change-Number: 8910 Gerrit-PatchSet: 3 Gerrit-Owner: Michael= Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Rev= iewer: Joe McDonnell Gerrit-Reviewer: Lars Vo= lker Gerrit-Reviewer: Michael Ho = Gerrit-Reviewer: Sailesh Mukil --DCFFe7DEzqE=--