impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6382: Cap default and min spillable buffer size query options
Date Sat, 13 Jan 2018 01:37:09 GMT
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9023


Change subject: IMPALA-6382: Cap default and min spillable buffer size query options
......................................................................

IMPALA-6382: Cap default and min spillable buffer size query options

Currently the default and min spillable buffer size query options
accept any value that is a power of 2. Since the planner depends on
these values for memory estimations, if a very large value close to
the limits of int64 is set, the variables representing or relying on
these estimates can overflow during different phases of query execution.

This patch puts a reasonable upper limit of 1TB to these query options
to prevent such a situation.

Testing:
Added backend query option tests.

Change-Id: I36d3915f7019b13c3eb06f08bfdb38c71ec864f1
---
M be/src/exec/exec-node.h
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
3 files changed, 17 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/9023/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36d3915f7019b13c3eb06f08bfdb38c71ec864f1
Gerrit-Change-Number: 9023
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message