impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups
Date Fri, 12 Jan 2018 21:48:27 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9002 )

Change subject: IMPALA-6383: free memory after skipping parquet row groups
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9002/4/be/src/exec/hdfs-parquet-scanner.h
File be/src/exec/hdfs-parquet-scanner.h:

http://gerrit.cloudera.org:8080/#/c/9002/4/be/src/exec/hdfs-parquet-scanner.h@647
PS4, Line 647:   /// were returned and when returning the last batch.
> What does the last part about "when returning the last batch mean"? Isn't t
Good point, removed.



-- 
To view, visit http://gerrit.cloudera.org:8080/9002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc2f8f27c9b238be60261539f8d4be2facb57a2b
Gerrit-Change-Number: 9002
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 21:48:27 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message