impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6386: Invalidate metadata at table level for dataload
Date Fri, 12 Jan 2018 21:29:54 GMT
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9009 )

Change subject: IMPALA-6386: Invalidate metadata at table level for dataload
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

Looks good, I have only minor comments.

http://gerrit.cloudera.org:8080/#/c/9009/2/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/9009/2/testdata/bin/generate-schema-statements.py@492
PS2, Line 492:     impala_output = Statements()
Maybe s/impala_output/impala_create/g


http://gerrit.cloudera.org:8080/#/c/9009/2/testdata/bin/generate-schema-statements.py@702
PS2, Line 702:   hive_output.write_to_file('load-' + output_name + '-hive-generated.sql')
Ideally these names should match as well (hive_load, hbase_load), but it is easy to dig a
hole messing around with a 200+ line function.  Up to you.



-- 
To view, visit http://gerrit.cloudera.org:8080/9009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc3a6d8a674a0bf6b02069bfe8a5e12034335b1f
Gerrit-Change-Number: 9009
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 21:29:54 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message