impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Date Fri, 12 Jan 2018 20:00:09 GMT
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 )

Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................


Patch Set 4: Code-Review+2

(2 comments)

Carrying forward +2 after minor update.

http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml
File docs/topics/impala_set.xml:

http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml@54
PS3, Line 54:         In <keyword keyref="impala211_full"/> and higher, the output of
the <codeph>SET</codeph>
> nit: I'm not sure how you treat trailing spaces in docs. Would you mind dro
Done


http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml@69
PS3, Line 69:             related to internal development of Impala or features that are not
yet finalized;
> Is it worth explicitly saying something like "Development query options may
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkaszab@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 20:00:09 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message