impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables
Date Thu, 11 Jan 2018 21:38:38 GMT
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851
)

Change subject: IMPALA-3193: Show table's comment on show tables
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8851/5/common/thrift/Frontend.thrift
File common/thrift/Frontend.thrift:

http://gerrit.cloudera.org:8080/#/c/8851/5/common/thrift/Frontend.thrift@70
PS5, Line 70: Arguments to getTableNamesAndComments
I think we can clean up the API a bit. Instead of having getTableNames and getTableNamesAndComments,
how about we create a single getTablesInfo call that takes a TGetTablesInfoParams (renamed
TGetTablesParams) argument and returns a TGetTablesInfoResult (renamed TGetTablesResult).
The latter returns a list<TTableInfo>, where TTableInfo has a required name and optional
comment field. That way, we avoid the checks around the length of list of names and list of
comments and it's easier to expand it if in the future we decide to add additional information
such as table creation time, owner, etc.



-- 
To view, visit http://gerrit.cloudera.org:8080/8851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44f814af05db6f3c027718ade9f474f8b8153bcd
Gerrit-Change-Number: 8851
Gerrit-PatchSet: 5
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Comment-Date: Thu, 11 Jan 2018 21:38:38 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message