impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.
Date Thu, 11 Jan 2018 04:15:57 GMT
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8888
)

Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic
linking.
......................................................................


Patch Set 4:

The error was:

03:17:23 =================================== FAILURES ===================================
03:17:23 ____________ TestObservability.test_query_profile_thrift_timestamps ____________
03:17:23 [gw6] linux2 -- Python 2.7.12 /home/ubuntu/Impala/bin/../infra/python/env/bin/python
03:17:23 query_test/test_observability.py:177: in test_query_profile_thrift_timestamps
03:17:23     assert False, dgb_str
03:17:23 E   NameError: global name 'dgb_str' is not defined

I'll fix the typo and re-run the test. I don't know if it's flaky, or perhaps the error message
will tell us something useful.


-- 
To view, visit http://gerrit.cloudera.org:8080/8888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dd807f869a9359d991ba515177fb2298054520e
Gerrit-Change-Number: 8888
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jan 2018 04:15:57 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message