impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6371: Additional check for delimiters
Date Wed, 10 Jan 2018 22:31:32 GMT
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8959
)

Change subject: IMPALA-6371: Additional check for delimiters
......................................................................

IMPALA-6371: Additional check for delimiters

The check validates the codepoint of the Java char.

Testing:
- Added tests for valid/invalid unicode in HdfsStorageDescriptorTest.

Change-Id: If8dc335d39dd02f602cf93682bccf84b2c099dde
Reviewed-on: http://gerrit.cloudera.org:8080/8959
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
M fe/src/test/java/org/apache/impala/catalog/HdfsStorageDescriptorTest.java
2 files changed, 24 insertions(+), 1 deletion(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8959
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If8dc335d39dd02f602cf93682bccf84b2c099dde
Gerrit-Change-Number: 8959
Gerrit-PatchSet: 5
Gerrit-Owner: Adam Holley <git@holleyism.com>
Gerrit-Reviewer: Adam Holley <git@holleyism.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message