impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabor Kaszab (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE
Date Wed, 10 Jan 2018 10:02:17 GMT
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 )

Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE
......................................................................


Patch Set 11:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8820/10/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/8820/10/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@347
PS10, Line 347: Generates a Kudu table name based on the target database and table and stores
              :    * it in TableDef.generatedKuduTableName_. Throws if
> Maybe "Generates a Kudu table name based on the target database and table a
Thanks for the suggestion! That sounds in fact better.


http://gerrit.cloudera.org:8080/#/c/8820/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/8820/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2043
PS10, Line 2043: AnalysisError
> Do you have a positive test where you set both the table name and EXTERNAL=
That scenario fails currently due to some checks in catalog.
Opened a Jira to cover:
https://issues.apache.org/jira/browse/IMPALA-6375


http://gerrit.cloudera.org:8080/#/c/8820/10/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test:

http://gerrit.cloudera.org:8080/#/c/8820/10/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test@347
PS10, Line 347: # Ensure the Kudu table is accessible
              : select count(*) from tbl_to_alter
              : ---- RESULTS
              : 5
> This is kind of redundant I think with the other analysis tests, remove?
It is, dropped.


http://gerrit.cloudera.org:8080/#/c/8820/9/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/8820/9/tests/query_test/test_kudu.py@327
PS9, Line 327: schema_builder.set_primary_keys(["id"])
             :     schema = schema_builder.build()
             : 
             :     name = unique_database + ".unbounded_range_table"
             : 
             :     try:
             :       kudu_client.create_table(name, 
> Yes, if it is testing the same thing.
Sure, dropped this.



-- 
To view, visit http://gerrit.cloudera.org:8080/8820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieca037498abf8f5fde67b77e824b720482cdbe6f
Gerrit-Change-Number: 8820
Gerrit-PatchSet: 11
Gerrit-Owner: Gabor Kaszab <gaborkaszab@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkaszab@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <boroknagyz@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jan 2018 10:02:17 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message