impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vuk Ercegovac (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
Date Wed, 10 Jan 2018 06:49:52 GMT
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 )

Change subject: IMPALA-1767: [DOCS] Document new Boolean operators
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8942/3/docs/topics/impala_operators.xml
File docs/topics/impala_operators.xml:

http://gerrit.cloudera.org:8080/#/c/8942/3/docs/topics/impala_operators.xml@1245
PS3, Line 1245: In <keyword keyref="impala211_full"/> and higher, you can use
              :         the operators <codeph>IS [NOT] TRUE</codeph> and
              :         <codeph>IS [NOT] FALSE</codeph> to perform <q>null-safe</q>
              :         tests against Boolean expressions. These operators always
              :         return <codeph>TRUE</codeph> or <codeph>FALSE</codeph>,
              :         even if the other side of the expression evaluates to
              :         <codeph>NULL</codeph>. These operators let you simplify
              :         Boolean comparisons that must also check for <codeph>NULL</codeph>,
              :         for example <codeph>X != 10 AND X IS NOT NULL</codeph>
is equivalent
              :         to <codeph>(X != 10) IS TRUE</codeph>.
              :       </p>
why is this explained here for IS UNKNOWN ? its a repeat of the content for the IS TRUE section.


http://gerrit.cloudera.org:8080/#/c/8942/3/docs/topics/impala_operators.xml@1260
PS3, Line 1260: IS [NOT] NULL
same thing twice. perhaps the first one should be IS [NOT] UNKNOWN ?


http://gerrit.cloudera.org:8080/#/c/8942/3/docs/topics/impala_operators.xml@1332
PS3, Line 1332: UNKNOWN
TRUE ? (UNKNOWN is handled in the prev section)



-- 
To view, visit http://gerrit.cloudera.org:8080/8942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb
Gerrit-Change-Number: 8942
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercegovac@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jan 2018 06:49:52 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message