impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6371: Additional check for delimiters
Date Wed, 10 Jan 2018 05:51:01 GMT
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8959 )

Change subject: IMPALA-6371: Additional check for delimiters
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/8959/3/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
File fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java:

http://gerrit.cloudera.org:8080/#/c/8959/3/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java@145
PS3, Line 145:         // e.g. \u1111 as delimVal will return a valid byte '11' 
whitespace


http://gerrit.cloudera.org:8080/#/c/8959/3/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java@147
PS3, Line 147:         if (cp<0 || cp>255) return null;
style: if (cp < 0 || cp > 255) return null;


http://gerrit.cloudera.org:8080/#/c/8959/3/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java@148
PS3, Line 148:         return (byte) delimVal.charAt(0);
return (byte) cp;


http://gerrit.cloudera.org:8080/#/c/8959/3/fe/src/test/java/org/apache/impala/catalog/HdfsStorageDescriptorTest.java
File fe/src/test/java/org/apache/impala/catalog/HdfsStorageDescriptorTest.java:

http://gerrit.cloudera.org:8080/#/c/8959/3/fe/src/test/java/org/apache/impala/catalog/HdfsStorageDescriptorTest.java@161
PS3, Line 161:     sd.getSerdeInfo().setParameters(new HashMap<String,String>());
brief comment what this is testing


http://gerrit.cloudera.org:8080/#/c/8959/3/fe/src/test/java/org/apache/impala/catalog/HdfsStorageDescriptorTest.java@172
PS3, Line 172:     sd.getSerdeInfo().setParameters(new HashMap<String,String>());
brief comment what this is testing



-- 
To view, visit http://gerrit.cloudera.org:8080/8959
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8dc335d39dd02f602cf93682bccf84b2c099dde
Gerrit-Change-Number: 8959
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <git@holleyism.com>
Gerrit-Reviewer: Adam Holley <git@holleyism.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jan 2018 05:51:01 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message