impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command
Date Sat, 06 Jan 2018 05:09:45 GMT
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928
)

Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8928/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/8928/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2281
PS3, Line 2281: if (rowFormat.getFieldDelimiter() != null) {
              :             sd.getSerdeInfo().putToParameters(
              :                 "serialization.format", rowFormat.getFieldDelimiter());
              :             sd.getSerdeInfo().putToParameters("field.delim",
              :                 rowFormat.getFieldDelimiter());
              :         }
              :         if (rowFormat.getEscapeChar() != null) {
              :             sd.getSerdeInfo().putToParameters("escape.delim", rowFormat.getEscapeChar());
              :         }
              :         if (rowFormat.getLineDelimiter() != null) {
              :             sd.getSerdeInfo().putToParameters("line.delim", rowFormat.getLineDelimiter());
              :         }
> That block is similar to the block between L2305-2318. I believe you should
Sorry, I meant SerDeInfo not StorageDescriptor. For the case of HdfsPartition you get it by
calling getSerdeInfo() and for the case of table you get it from the StorageDescriptor.



-- 
To view, visit http://gerrit.cloudera.org:8080/8928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96e347463504915a6f33932552e4d1f61e9b1154
Gerrit-Change-Number: 8928
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <git@holleyism.com>
Gerrit-Reviewer: Adam Holley <git@holleyism.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Comment-Date: Sat, 06 Jan 2018 05:09:45 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message