impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6370: fix partitioned parquet tables with nested types
Date Fri, 05 Jan 2018 16:50:13 GMT
Hello Thomas Tauber-Marshall, Alex Behm, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8947

to look at the new patch set (#3).

Change subject: IMPALA-6370: fix partitioned parquet tables with nested types
......................................................................

IMPALA-6370: fix partitioned parquet tables with nested types

When materialising a nested collection, has_template_tuple() should use
the template tuple for the collection, not the top-level tuple.

Testing:
Added tests based on nested-types-basic.test that operate on a simple
partitioned table. The tests reliably crashed Impala before the fix.

Change-Id: Ic808b824ce3b31af0539036d8ca23d17b18deab4
---
M be/src/exec/hdfs-scanner.h
A testdata/workloads/functional-query/queries/QueryTest/nested-types-basic-partitioned.test
M tests/query_test/test_nested_types.py
3 files changed, 385 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/8947/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic808b824ce3b31af0539036d8ca23d17b18deab4
Gerrit-Change-Number: 8947
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message