impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6355: fix overflow DCHECK in decimal mod
Date Wed, 03 Jan 2018 20:27:31 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8929 )

Change subject: IMPALA-6355: fix overflow DCHECK in decimal mod
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8929/1/be/src/runtime/decimal-value.inline.h
File be/src/runtime/decimal-value.inline.h:

http://gerrit.cloudera.org:8080/#/c/8929/1/be/src/runtime/decimal-value.inline.h@571
PS1, Line 571:  DCHECK(!ovf)
> is overflow here a valid case? if yes, should we return it in '*overflow' i
It shouldn't be. I believe that the properties of decimal mod and the way the planner chooses
the output precision/scale guarantee that the result should always fit in the output type



-- 
To view, visit http://gerrit.cloudera.org:8080/8929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd7ac691155442ba7cba71dd3647208b7c1c0bf9
Gerrit-Change-Number: 8929
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2018 20:27:31 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message