impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms
Date Tue, 02 Jan 2018 22:25:39 GMT
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8910
)

Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................

IMPALA-5557: Disable rpc_default_keepalive_time_ms

This change makes sure backend connections with KRPC are always
kept alive by disabling the idle connection detection logic.

Idle connections all tend to be closed and re-opened around the
same time, which may easily lead to negotiation timeouts. Until
KUDU-279 is fixed, closing idle connections is also racy and leads
to query failures.

This disablement was validated with Kudu's rpc-test.

Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Reviewed-on: http://gerrit.cloudera.org:8080/8910
Reviewed-by: Michael Ho <kwho@cloudera.com>
Reviewed-by: Sailesh Mukil <sailesh@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/rpc/rpc-mgr.cc
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Michael Ho: Looks good to me, but someone else must approve
  Sailesh Mukil: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message