impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5528: Add a flag to tune TCMalloc total thread caches size
Date Tue, 02 Jan 2018 19:40:19 GMT
Hello Lars Volker, Sailesh Mukil, Tim Armstrong, Joe McDonnell, Mostafa Mokhtar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8906

to look at the new patch set (#3).

Change subject: IMPALA-5528: Add a flag to tune TCMalloc total thread caches size
......................................................................

IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

This change adds a new flag FLAGS_tcmalloc_max_total_thread_cache_bytes
which specifies the maximum size in bytes which the total of all TCMalloc
thread caches can grow to. By default, it's set to 0 and the default value
in TCMalloc library is used.  This change also always enables "aggressive
decommit" feature in TCMalloc instead of just validating that it's enabled
in the code by default.

Testing done: core build;
test_tpch.py with FLAGS_tcmalloc_max_total_thread_cache_bytes set.

Change-Id: Ib968ee7d20458143ef6ac14ad3ac2c4d84d31dc5
---
M be/src/common/global-flags.cc
M be/src/runtime/exec-env.cc
2 files changed, 22 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/8906/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib968ee7d20458143ef6ac14ad3ac2c4d84d31dc5
Gerrit-Change-Number: 8906
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message