Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4725F200D4E for ; Thu, 7 Dec 2017 21:00:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 45929160C0C; Thu, 7 Dec 2017 20:00:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8AB44160C08 for ; Thu, 7 Dec 2017 21:00:14 +0100 (CET) Received: (qmail 73422 invoked by uid 500); 7 Dec 2017 20:00:13 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 73411 invoked by uid 99); 7 Dec 2017 20:00:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Dec 2017 20:00:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 01B101806E9 for ; Thu, 7 Dec 2017 20:00:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id hE1ry3bd9ocz for ; Thu, 7 Dec 2017 20:00:10 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E8CA262694 for ; Thu, 7 Dec 2017 18:12:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vB7ICedv026333; Thu, 7 Dec 2017 18:12:40 GMT X-Gerrit-PatchSet: 1 Date: Thu, 7 Dec 2017 18:12:40 +0000 From: "Laszlo Gaal (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5Bnative-toolchain-CR=5D_Prepare_to_move_automated_toolchain_builds_to_a_new_environment=0A?= X-Gerrit-Change-Id: I08d26206e33aa142b8c166aefe21ac1315fdbd3a X-Gerrit-Change-Number: 8787 X-Gerrit-ChangeURL: X-Gerrit-Commit: 981e1b0fd6fd1308f6e24ce138edfeede8652c5a Reply-To: laszlo.gaal@cloudera.com, impala-cr@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="Q5JGAtMXgWo="; charset=UTF-8 archived-at: Thu, 07 Dec 2017 20:00:15 -0000 --Q5JGAtMXgWo= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Laszlo Gaal has uploaded this change for review=2E ( http://gerrit=2Ecloude= ra=2Eorg:8080/8787 Change subject: Prepare to move automated toolchain bu= ilds to a new environment =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E Prepare to move automated toolchain builds to a new environme= nt This change updates the build scripts so that builds can take advantage= of preconfigured Amazon EC2 VM instances, where S3 credentials can be supp= lied by IAM roles instead of environment variables=2E Consequently, the cr= edential checking logic before the S3 upload is removed from functions=2Esh= , where the binary artifacts are copied to S3 using AWSCLI=2E AWSCLI will a= ttempt to authenticate anyway, and the script already has logic to decide w= hether an upload failure should fail the whole build process, so there is n= o real value in performing a similar check in the script at the same locati= on=2E There are also a couple of typos fixed in various comments=2E Chang= e-Id: I08d26206e33aa142b8c166aefe21ac1315fdbd3a --- M functions=2Esh M init= -compiler=2Esh M init=2Esh 3 files changed, 6 insertions(+), 21 deletions(-= ) git pull ssh://gerrit=2Ecloudera=2Eorg:29418/native-toolchain refs/c= hanges/87/8787/1 -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/878= 7 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerri= t-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newch= ange Gerrit-Change-Id: I08d26206e33aa142b8c166aefe21ac1315fdbd3a Gerrit-Cha= nge-Number: 8787 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal --Q5JGAtMXgWo=--