Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9DCAC200D71 for ; Thu, 21 Dec 2017 03:30:39 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9C484160C18; Thu, 21 Dec 2017 02:30:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E26F5160C15 for ; Thu, 21 Dec 2017 03:30:38 +0100 (CET) Received: (qmail 87827 invoked by uid 500); 21 Dec 2017 02:30:38 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 87816 invoked by uid 99); 21 Dec 2017 02:30:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Dec 2017 02:30:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 58378C40C9 for ; Thu, 21 Dec 2017 02:30:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4Pe0N878nPbW for ; Thu, 21 Dec 2017 02:30:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D89785F30B for ; Thu, 21 Dec 2017 02:30:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vBL2UYDP027833; Thu, 21 Dec 2017 02:30:34 GMT Message-Id: <201712210230.vBL2UYDP027833@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Thu, 21 Dec 2017 02:30:33 +0000 From: "Matthew Mulder (Code Review)" To: David Knupp , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Brown , Philip Zeyliger X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Move_symlinked_auxiliary_tests/*_to_tests/functional/*=0A?= X-Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b X-Gerrit-Change-Number: 8896 X-Gerrit-ChangeURL: X-Gerrit-Commit: d7de1496d71c648ca6b89b0d2d9362e24f3c5c8e In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 21 Dec 2017 02:30:33 +0000 Reply-To: mmulder@cloudera.com, impala-cr@cloudera.com, dknupp@cloudera.com, marcelk@gmail.com, philip@cloudera.com, reviews@impala.incubator.apache.org, mikeb@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="qxbTK3QAC0E="; charset=UTF-8 archived-at: Thu, 21 Dec 2017 02:30:39 -0000 --qxbTK3QAC0E= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Matthew Mulder has posted comments on this change=2E ( http://gerrit=2Eclou= dera=2Eorg:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to= tests/functional/* =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 3: Code-Review+1 (1 comment) I ran just that bit of sc= ript that creates the test links and it works with or without the functiona= l dir=2E http://gerrit=2Ecloudera=2Eorg:8080/#/c/8896/2/bin/create-test-co= nfiguration=2Esh File bin/create-test-configuration=2Esh: http://gerrit=2E= cloudera=2Eorg:8080/#/c/8896/2/bin/create-test-configuration=2Esh@195 PS2, = Line 195: > Good catch=2E Thanks=2E Done -- To view, visit http://ger= rit=2Ecloudera=2Eorg:8080/8896 To unsubscribe, visit http://gerrit=2Ecloude= ra=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Ge= rrit-MessageType: comment Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd9= 18b7d99b3b Gerrit-Change-Number: 8896 Gerrit-PatchSet: 3 Gerrit-Owner: Davi= d Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Matthew Mulder Gerrit-R= eviewer: Michael Brown Gerrit-Reviewer: Philip Zeyli= ger Gerrit-Comment-Date: Thu, 21 Dec 2017 02:30:33 = +0000 Gerrit-HasComments: Yes --qxbTK3QAC0E=--