Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B4D8A200D61 for ; Tue, 19 Dec 2017 20:01:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B3654160C2A; Tue, 19 Dec 2017 19:01:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 04E27160BFF for ; Tue, 19 Dec 2017 20:01:49 +0100 (CET) Received: (qmail 95347 invoked by uid 500); 19 Dec 2017 19:01:49 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 95333 invoked by uid 99); 19 Dec 2017 19:01:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Dec 2017 19:01:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8A94AC5CD4 for ; Tue, 19 Dec 2017 19:01:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fAxJfOAoPu4Q for ; Tue, 19 Dec 2017 19:01:47 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 881FF5F3BB for ; Tue, 19 Dec 2017 19:01:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vBJJ1kBH031619; Tue, 19 Dec 2017 19:01:46 GMT Message-Id: <201712191901.vBJJ1kBH031619@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Tue, 19 Dec 2017 19:01:46 +0000 From: "Philip Zeyliger (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Thomas Tauber-Marshall X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Remove_unused_deps=2C_centralize_some_pom_versions=2C_upgrade_SLF4J_and_commons-io=2E=0A?= X-Gerrit-Change-Id: I717e0625dfe0fdbf7e9161312e9e80f405a359c5 X-Gerrit-Change-Number: 8853 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3d70fb8dcc7c7b44debdea7ae1d8cc18cd8ea162 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 19 Dec 2017 19:01:46 +0000 Reply-To: philip@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tmarshall@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="AIPjPkJJga0="; charset=UTF-8 archived-at: Tue, 19 Dec 2017 19:01:50 -0000 --AIPjPkJJga0= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Philip Zeyliger has posted comments on this change=2E ( http://gerrit=2Eclo= udera=2Eorg:8080/8853 ) Change subject: Remove unused deps, centralize som= e pom versions, upgrade SLF4J and commons-io=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Patch Set 2: (3 comments) Thanks for = the review, Thomas=2E Good catch on IMPALA_JAVA_THRIFT_VERSION=2E I update= d the change, and added the commons=2Eio change which was hanging out uncom= mitted=2E https://jenkins=2Eimpala=2Eio/job/gerrit-verify-dryrun-external/= 40/ is running with this new patch http://gerrit=2Ecloudera=2Eorg:8080/#/c= /8853/2/bin/impala-config=2Esh File bin/impala-config=2Esh: http://gerrit= =2Ecloudera=2Eorg:8080/#/c/8853/2/bin/impala-config=2Esh@142 PS2, Line 142:= IMPALA_THRIFT_JAVA_VERSION > Is this still being used anywhere now? Should= have been :) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8853/2/impala-paren= t/pom=2Exml File impala-parent/pom=2Exml: http://gerrit=2Ecloudera=2Eorg:8= 080/#/c/8853/2/impala-parent/pom=2Exml@48 PS2, Line 48: 2=2E4 I changed this too; missed a diff in my= first post=2E http://gerrit=2Ecloudera=2Eorg:8080/#/c/8853/2/impala-pare= nt/pom=2Exml@57 PS2, Line 57: 0=2E9=2E0< > Should this be env=2EIMPALA_THRI= FT_VERSION? Good eye; this should be IMPALA_JAVA_THRIFT_VERSION=2E -- T= o view, visit http://gerrit=2Ecloudera=2Eorg:8080/8853 To unsubscribe, visi= t http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF = Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I717e06= 25dfe0fdbf7e9161312e9e80f405a359c5 Gerrit-Change-Number: 8853 Gerrit-PatchS= et: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer= : Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Thomas Tauber-Marshall = Gerrit-Comment-Date: Tue, 19 Dec 2017 19:01:46 +0000 Gerrit-HasComments: Ye= s --AIPjPkJJga0=--