Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201712190345.vBJ3jlNa022876@ip-10-146-233-104.ec2.internal>
Date: Tue, 19 Dec 2017 03:45:47 +0000
From: "Michael Ho (Code Review)" <gerrit@cloudera.org>
To: Lars Volker <lv@cloudera.com>, Dan Burkert <danburkert@apache.org>,
        Sailesh Mukil <sailesh@cloudera.com>,
        Joe McDonnell <joemcdonnell@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_KUDU-2228=3A_Make_Messenger_options_configurable=0A?=
In-Reply-To: <gerrit.1513653865000.Ia21814ffb6e283c2791985b089878b579905f0ba@gerrit.cloudera.org>
References: <gerrit.1513653865000.Ia21814ffb6e283c2791985b089878b579905f0ba@gerrit.cloudera.org>
Reply-To: kwho@cloudera.com, impala-cr@cloudera.com, sailesh@cloudera.com,
        lv@cloudera.com, marcelk@gmail.com, danburkert@apache.org,
        joemcdonnell@cloudera.com, reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="YMRbGiEYdn0="; charset=UTF-8
archived-at: Tue, 19 Dec 2017 03:45:54 -0000

--YMRbGiEYdn0=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Lars Volker, Dan Burkert, Kudu Jenkins, Sailesh Mukil, Joe McDonnell,=
 

I'd like you to reexamine a change=2E Please visit

    http://gerrit=2E=
cloudera=2Eorg:8080/8878

to look at the new patch set (#2)=2E

Change subj=
ect: KUDU-2228: Make Messenger options configurable
=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E

KUDU-2228: Make Messenger options =
configurable

Currently, the RPC layer accesses many gflags directly to tak=
e
certain decisions, eg=2E whether to turn on encryption,
authentication, e=
tc=2E

Since the RPC layer is to be used more like a library, these should
=
be configurable options that are passed to the Messenger
(which is the API =
endpoint for the application using the RPC layer),
instead of the RPC layer=
 itself directly accessing these flags=2E

This patch converts the followin=
g flags to Messenger options and moves
the flag definitions to server_base=
=2Ecc which is the "application" in
Kudu that uses the Messenger:

FLAGS_rp=
c_default_keepalive_time_ms
FLAGS_rpc_negotiation_timeout_ms
FLAGS_rpc_auth=
entication
FLAGS_rpc_encryption
FLAGS_rpc_tls_ciphers
FLAGS_rpc_tls_min_pro=
tocol
FLAGS_rpc_certificate_file
FLAGS_rpc_private_key_file
FLAGS_rpc_ca_ce=
rtificate_file
FLAGS_rpc_private_key_password_cmd
FLAGS_keytab_file

Most o=
f the remaining flags are test or benchmark related flags=2E There
may be a=
 few more flags that can be moved out and converted to options,
but we can =
leave that as future work if we decide to move them=2E

Change-Id: Ia21814f=
fb6e283c2791985b089878b579905f0ba
Reviewed-on: http://gerrit=2Ecloudera=2Eo=
rg:8080/8789
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <danburkert@a=
pache=2Eorg>
---
M be/src/kudu/rpc/client_negotiation=2Ecc
M be/src/kudu/rp=
c/client_negotiation=2Eh
M be/src/kudu/rpc/messenger=2Ecc
M be/src/kudu/rpc=
/messenger=2Eh
M be/src/kudu/rpc/negotiation=2Ecc
M be/src/kudu/rpc/negotia=
tion=2Eh
M be/src/kudu/rpc/reactor=2Ecc
M be/src/kudu/rpc/rpc-test-base=2Eh=

M be/src/kudu/rpc/rpc-test=2Ecc
M be/src/kudu/rpc/sasl_common=2Ecc
M be/sr=
c/kudu/rpc/sasl_common=2Eh
M be/src/kudu/rpc/server_negotiation=2Ecc
M be/s=
rc/kudu/rpc/server_negotiation=2Eh
M be/src/kudu/security/CMakeLists=2Etxt
=
M be/src/kudu/security/init=2Ecc
M be/src/kudu/security/init=2Eh
A be/src/k=
udu/security/security_flags=2Ecc
A be/src/kudu/security/security_flags=2Eh
=
M be/src/kudu/security/test/mini_kdc-test=2Ecc
M be/src/kudu/security/tls_c=
ontext=2Ecc
M be/src/kudu/security/tls_context=2Eh
M be/src/kudu/util/flags=
=2Ecc
M be/src/kudu/util/flags=2Eh
M be/src/rpc/authentication=2Ecc
24 file=
s changed, 381 insertions(+), 282 deletions(-)


  git pull ssh://gerrit=2E=
cloudera=2Eorg:29418/Impala-ASF refs/changes/78/8878/2
-- 
To view, visit h=
ttp://gerrit=2Ecloudera=2Eorg:8080/8878
To unsubscribe, visit http://gerrit=
=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: =
master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia21814ffb6e283c27=
91985b089878b579905f0ba
Gerrit-Change-Number: 8878
Gerrit-PatchSet: 2
Gerri=
t-Owner: Michael Ho <kwho@cloudera=2Ecom>
Gerrit-Reviewer: Dan Burkert <dan=
burkert@apache=2Eorg>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera=
=2Ecom>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker <lv@clou=
dera=2Ecom>
Gerrit-Reviewer: Michael Ho <kwho@cloudera=2Ecom>
Gerrit-Review=
er: Sailesh Mukil <sailesh@cloudera=2Ecom>

--YMRbGiEYdn0=--