Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D01DB200D66 for ; Fri, 15 Dec 2017 02:00:41 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CE89F160C25; Fri, 15 Dec 2017 01:00:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1EFE3160C16 for ; Fri, 15 Dec 2017 02:00:40 +0100 (CET) Received: (qmail 29834 invoked by uid 500); 15 Dec 2017 01:00:40 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 29823 invoked by uid 99); 15 Dec 2017 01:00:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Dec 2017 01:00:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8B9C4C6056 for ; Fri, 15 Dec 2017 01:00:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YAFOzMHqghw1 for ; Fri, 15 Dec 2017 01:00:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id EAB765F39F for ; Fri, 15 Dec 2017 01:00:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vBF10awW023106; Fri, 15 Dec 2017 01:00:36 GMT Message-Id: <201712150100.vBF10awW023106@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Fri, 15 Dec 2017 01:00:35 +0000 From: "Tim Armstrong (Code Review)" To: Gabor Kaszab , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm , Attila Jeges , Laszlo Gaal , Csaba Ringhofer , Zoltan Borok-Nagy X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5654=3A_Disallow_setting_Kudu_table_name_in_CREATE_TABLE=0A?= X-Gerrit-Change-Id: Ieca037498abf8f5fde67b77e824b720482cdbe6f X-Gerrit-Change-Number: 8820 X-Gerrit-ChangeURL: X-Gerrit-Commit: d69c7702dfacca578ff0f9774fd3617360a57d54 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 15 Dec 2017 01:00:35 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, boroknagyz@cloudera.com, gaborkaszab@cloudera.com, marcelk@gmail.com, laszlo.gaal@cloudera.com, csringhofer@cloudera.com, attilaj@cloudera.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="TbUW+atw/2M="; charset=UTF-8 archived-at: Fri, 15 Dec 2017 01:00:42 -0000 --TbUW+atw/2M= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu t= able name in CREATE TABLE =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E Patch Set 4: (1 comment) The code and tests look good to m= e, had one outstanding question that came out of a discussion=2E http://ge= rrit=2Ecloudera=2Eorg:8080/#/c/8820/4//COMMIT_MSG Commit Message: http://g= errit=2Ecloudera=2Eorg:8080/#/c/8820/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-56= 54: Disallow setting Kudu table name in CREATE TABLE Gabor mentioned to me = offline that we might want to catch it in alter table too (unsure if that i= s already disallowed)=2E -- To view, visit http://gerrit=2Ecloudera=2Eo= rg:8080/8820 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/sett= ings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: = comment Gerrit-Change-Id: Ieca037498abf8f5fde67b77e824b720482cdbe6f Gerrit-= Change-Number: 8820 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Alex Behm = Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Cs= aba Ringhofer Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerr= it-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-D= ate: Fri, 15 Dec 2017 01:00:35 +0000 Gerrit-HasComments: Yes --TbUW+atw/2M=--