Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8115C200D66 for ; Thu, 14 Dec 2017 17:33:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7F99B160BFC; Thu, 14 Dec 2017 16:33:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C89F5160C16 for ; Thu, 14 Dec 2017 17:33:09 +0100 (CET) Received: (qmail 33209 invoked by uid 500); 14 Dec 2017 16:33:09 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 33152 invoked by uid 99); 14 Dec 2017 16:33:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Dec 2017 16:33:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 510DEC59D9 for ; Thu, 14 Dec 2017 16:33:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id GKMo6PhZX2yi for ; Thu, 14 Dec 2017 16:33:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E58CA5FBC7 for ; Thu, 14 Dec 2017 16:33:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vBEGX3pH009573; Thu, 14 Dec 2017 16:33:03 GMT Message-Id: <201712141633.vBEGX3pH009573@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 5 Date: Thu, 14 Dec 2017 16:33:03 +0000 From: "Zoltan Borok-Nagy (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm , Tim Armstrong , Taras Bobrovytsky X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5191=3A_Standardize_column_alias_behavior=0A?= X-Gerrit-Change-Id: I0f82483b486acf6953876cfa672b0d034f3709a8 X-Gerrit-Change-Number: 8801 X-Gerrit-ChangeURL: X-Gerrit-Commit: 063284deb9a62706f7c234654ebea8e360d46260 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 14 Dec 2017 16:33:03 +0000 Reply-To: boroknagyz@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, tbobrovytsky@cloudera.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="7Y9WtRVXwts="; charset=UTF-8 archived-at: Thu, 14 Dec 2017 16:33:10 -0000 --7Y9WtRVXwts= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Zoltan Borok-Nagy has posted comments on this change=2E ( http://gerrit=2Ec= loudera=2Eorg:8080/8801 ) Change subject: IMPALA-5191: Standardize column = alias behavior =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= Patch Set 5: (2 comments) Thanks for the comments! http://gerrit=2Ecl= oudera=2Eorg:8080/#/c/8801/5//COMMIT_MSG Commit Message: http://gerrit=2Ec= loudera=2Eorg:8080/#/c/8801/5//COMMIT_MSG@14 PS5, Line 14: SELECT int_col /= 2 AS x > Do we have existing end-to-end tests for queries of these forms? = Would be g Added a new file called alias=2Etest http://gerrit=2Ecloudera= =2Eorg:8080/#/c/8801/5/fe/src/main/java/org/apache/impala/analysis/Expr=2Ej= ava File fe/src/main/java/org/apache/impala/analysis/Expr=2Ejava: http://g= errit=2Ecloudera=2Eorg:8080/#/c/8801/5/fe/src/main/java/org/apache/impala/a= nalysis/Expr=2Ejava@817 PS5, Line 817: boolean preserveRootType, boolean s= ubstituteChildren > Agreed=2E I like trySubstituteRecursive() and trySubsti= tuteRootOnly() I agree, I use the proposed trySubstituteRecursive() and try= SubstituteRootOnly() names=2E They both call the private trySubstitute() me= thod, which still has mulitple boolean flags=2E I didn't change the other = substitute methods where substituteChildren is the only flag=2E -- To v= iew, visit http://gerrit=2Ecloudera=2Eorg:8080/8801 To unsubscribe, visit h= ttp://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Ger= rit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f82483b4= 86acf6953876cfa672b0d034f3709a8 Gerrit-Change-Number: 8801 Gerrit-PatchSet:= 5 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Revie= wer: Alex Behm Gerrit-Reviewer: Taras Bobrovyt= sky Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 14 Dec 2017 16:33:03 +0000 Gerrit-HasComm= ents: Yes --7Y9WtRVXwts=--