Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9DB65200D68 for ; Thu, 14 Dec 2017 00:38:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9C381160C24; Wed, 13 Dec 2017 23:38:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E1A74160C23 for ; Thu, 14 Dec 2017 00:38:01 +0100 (CET) Received: (qmail 65744 invoked by uid 500); 13 Dec 2017 23:38:01 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 65731 invoked by uid 99); 13 Dec 2017 23:38:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Dec 2017 23:38:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 79510180951 for ; Wed, 13 Dec 2017 23:38:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id bx57r-giz6k9 for ; Wed, 13 Dec 2017 23:37:59 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 82C615F19D for ; Wed, 13 Dec 2017 23:37:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vBDNbuVn031052; Wed, 13 Dec 2017 23:37:56 GMT Message-Id: <201712132337.vBDNbuVn031052@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 5 Date: Wed, 13 Dec 2017 23:37:56 +0000 From: "Kim Jin Chul (Code Review)" To: John Russell , Alex Behm , Vuk Ercegovac , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4168=3A_Adds_Oracle-style_hint_placement_for_INSERT/UPSERT=0A?= X-Gerrit-Change-Id: Ied7629d70197a0270cdc0853e00cc021fdb4dc20 X-Gerrit-Change-Number: 8676 X-Gerrit-ChangeURL: X-Gerrit-Commit: f180fec987425456e1fb1c3b7f81f32577a9d5aa In-Reply-To: References: Reply-To: jinchul@gmail.com, jrussell@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org, vercegovac@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="U8XRNhbcqkM="; charset=UTF-8 archived-at: Wed, 13 Dec 2017 23:38:02 -0000 --U8XRNhbcqkM= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a= change=2E Please visit http://gerrit=2Ecloudera=2Eorg:8080/8676 to l= ook at the new patch set (#5)=2E Change subject: IMPALA-4168: Adds Oracle-= style hint placement for INSERT/UPSERT =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E IMPALA-4168: Adds Oracle-style hint placement for= INSERT/UPSERT Testing: Add unit tests to ParserTest#TestPlanHints Add pla= n check tests to PlannerTest#testInsert, PlannerTest#testKuduUpsert Add que= ry rebuild tests to ToSqlTest#planHintsTest Change-Id: Ied7629d70197a0270c= dc0853e00cc021fdb4dc20 --- M fe/src/main/cup/sql-parser=2Ecup M fe/src/main= /java/org/apache/impala/analysis/CreateTableAsSelectStmt=2Ejava M fe/src/ma= in/java/org/apache/impala/analysis/InsertStmt=2Ejava M fe/src/test/java/org= /apache/impala/analysis/ParserTest=2Ejava M fe/src/test/java/org/apache/imp= ala/analysis/ToSqlTest=2Ejava M testdata/workloads/functional-planner/queri= es/PlannerTest/insert=2Etest M testdata/workloads/functional-planner/querie= s/PlannerTest/kudu-upsert=2Etest 7 files changed, 241 insertions(+), 83 del= etions(-) git pull ssh://gerrit=2Ecloudera=2Eorg:29418/Impala-ASF refs/= changes/76/8676/5 -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/86= 76 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerr= it-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchse= t Gerrit-Change-Id: Ied7629d70197a0270cdc0853e00cc021fdb4dc20 Gerrit-Change= -Number: 8676 Gerrit-PatchSet: 5 Gerrit-Owner: Kim Jin Chul Gerrit-Reviewer: Alex Behm Gerrit-Revi= ewer: John Russell Gerrit-Reviewer: Kim Jin Chul = Gerrit-Reviewer: Vuk Ercegovac --U8XRNhbcqkM=--