Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 45371200D68 for ; Thu, 14 Dec 2017 00:06:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 43B24160C24; Wed, 13 Dec 2017 23:06:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8950E160C23 for ; Thu, 14 Dec 2017 00:06:50 +0100 (CET) Received: (qmail 24781 invoked by uid 500); 13 Dec 2017 23:06:49 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 24768 invoked by uid 99); 13 Dec 2017 23:06:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Dec 2017 23:06:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 171E11805BF for ; Wed, 13 Dec 2017 23:06:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id YWLgSJz_FsFF for ; Wed, 13 Dec 2017 23:06:47 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2FC785F2EF for ; Wed, 13 Dec 2017 23:06:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vBDN6jdr030096; Wed, 13 Dec 2017 23:06:45 GMT Message-Id: <201712132306.vBDN6jdr030096@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Wed, 13 Dec 2017 23:06:45 +0000 From: "Impala Public Jenkins (Code Review)" To: Quanlong Huang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6301=3A_Fix_test_failures_when_username_or_group_name_contains_dots=0A?= X-Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b X-Gerrit-Change-Number: 8807 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5c593be59c725f004ead81af94931852410e3a1c In-Reply-To: References: Reply-To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org, huangquanlong@gmail.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="07Jt1uaEepw="; charset=UTF-8 archived-at: Wed, 13 Dec 2017 23:06:51 -0000 --07Jt1uaEepw= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Impala Public Jenkins has submitted this change and it was merged=2E ( http= ://gerrit=2Ecloudera=2Eorg:8080/8807 ) Change subject: IMPALA-6301: Fix te= st failures when username or group name contains dots =2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E IMPALA-6301: Fix test failures whe= n username or group name contains dots Some tests use the local user's gro= up name to construct SQLs, which may lead to syntax errors when group name = contains dots=2E We need to quote the group names in SQL to avoid this erro= r=2E Besides, a test in test_admission_controller uses '\w+' to match the l= ocal user name=2E This expression cannot match usernames with dots, which c= auses test failure as well=2E Instead, we should use '\S+'=2E Change-Id: I= b8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Reviewed-on: http://gerrit=2Ecloud= era=2Eorg:8080/8807 Reviewed-by: Thomas Tauber-Marshall Reviewed-by: Michael Ho Tested-by: Impala Pub= lic Jenkins --- M testdata/workloads/functional-query/queries/QueryTest/gra= nt_revoke=2Etest M testdata/workloads/functional-query/queries/QueryTest/gr= ant_revoke_kudu=2Etest M tests/authorization/test_grant_revoke=2Epy M tests= /custom_cluster/test_admission_controller=2Epy 4 files changed, 31 insertio= ns(+), 31 deletions(-) Approvals: Thomas Tauber-Marshall: Looks good to = me, but someone else must approve Michael Ho: Looks good to me, approved = Impala Public Jenkins: Verified -- To view, visit http://gerrit=2Ecloud= era=2Eorg:8080/8807 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:80= 80/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Messag= eType: merged Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b G= errit-Change-Number: 8807 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <= huangquanlong@gmail=2Ecom> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Re= viewer: Michael Ho Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Thomas Tauber-Marshall --07Jt1uaEepw=--