Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 54FC2200D56 for ; Tue, 12 Dec 2017 22:21:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 53801160C00; Tue, 12 Dec 2017 21:21:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 98895160BE7 for ; Tue, 12 Dec 2017 22:21:08 +0100 (CET) Received: (qmail 83354 invoked by uid 500); 12 Dec 2017 21:21:07 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 83337 invoked by uid 99); 12 Dec 2017 21:21:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Dec 2017 21:21:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2CF131A0C78 for ; Tue, 12 Dec 2017 21:21:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id viJPRQhYs4yM for ; Tue, 12 Dec 2017 21:21:06 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7B6FE5F3CF for ; Tue, 12 Dec 2017 21:21:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vBCLL3WL032679; Tue, 12 Dec 2017 21:21:03 GMT Message-Id: <201712122121.vBCLL3WL032679@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 5 Date: Tue, 12 Dec 2017 21:21:03 +0000 From: "Zoram Thanga (Code Review)" To: Zoram Thanga , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Alex Behm , Bharath Vissapragada , Michael Ho X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6114=3A_Require_type_equality_of_NumericLiteral=3A=3AlocalEquals=28=29=2E=0A?= X-Gerrit-Change-Id: Ia88d54088dfd128b103759dc01103b6c35bf6257 X-Gerrit-Change-Number: 8448 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9f29c75c6222bd3e366b8708e42a627ac8b349df In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 12 Dec 2017 21:21:03 +0000 Reply-To: zoram@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, kwho@cloudera.com, zoram@cloudera.com, alex.behm@cloudera.com, bharathv@cloudera.com, reviews@impala.incubator.apache.org, dtsirogiannis@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="y0Y/eVpQixM="; charset=UTF-8 archived-at: Tue, 12 Dec 2017 21:21:09 -0000 --y0Y/eVpQixM= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Zoram Thanga has posted comments on this change=2E ( http://gerrit=2Ecloude= ra=2Eorg:8080/8448 ) Change subject: IMPALA-6114: Require type equality of= NumericLiteral::localEquals()=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E Patch Set 5: > (1 comment) > > Thanks for the c= omments=2E Please see patch set #4=2E Correction: Please see patch set #5= =2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8448 To unsubs= cribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: = Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-= Id: Ia88d54088dfd128b103759dc01103b6c35bf6257 Gerrit-Change-Number: 8448 Ge= rrit-PatchSet: 5 Gerrit-Owner: Zoram Thanga Gerrit-R= eviewer: Alex Behm Gerrit-Reviewer: Bharath Vi= ssapragada Gerrit-Reviewer: Dimitris Tsirogiannis= Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Comment= -Date: Tue, 12 Dec 2017 21:21:03 +0000 Gerrit-HasComments: No --y0Y/eVpQixM=--