Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 150D4200D56 for ; Tue, 12 Dec 2017 18:54:43 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 13A1C160C00; Tue, 12 Dec 2017 17:54:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5B028160BE7 for ; Tue, 12 Dec 2017 18:54:42 +0100 (CET) Received: (qmail 11823 invoked by uid 500); 12 Dec 2017 17:54:41 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 11812 invoked by uid 99); 12 Dec 2017 17:54:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Dec 2017 17:54:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CEC4CC4C00 for ; Tue, 12 Dec 2017 17:54:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id nd4VhZ4BoFe5 for ; Tue, 12 Dec 2017 17:54:39 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 42D1B5F39F for ; Tue, 12 Dec 2017 17:54:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vBCHsbri025067; Tue, 12 Dec 2017 17:54:37 GMT Message-Id: <201712121754.vBCHsbri025067@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 9 Date: Tue, 12 Dec 2017 17:54:37 +0000 From: "Alex Behm (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Bharath Vissapragada , Dan Hecht , Jim Apple X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5310=3A_Part_2=3A_Add_SAMPLED_NDV=28=29_function=2E=0A?= X-Gerrit-Change-Id: Ia51d56ee67ec6073e92f90bebb4005484138b820 X-Gerrit-Change-Number: 8569 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1131743e4a358069397a2985746c2b2c0a5617fa In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 12 Dec 2017 17:54:37 +0000 Reply-To: alex.behm@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, dhecht@cloudera.com, jbapple-impala@apache.org, bharathv@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="60a64I+tql8="; charset=UTF-8 archived-at: Tue, 12 Dec 2017 17:54:43 -0000 --60a64I+tql8= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Alex Behm has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/8569 ) Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() = function=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E = Patch Set 9: (2 comments) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8569/9/= bin/rat_exclude_files=2Etxt File bin/rat_exclude_files=2Etxt: http://gerri= t=2Ecloudera=2Eorg:8080/#/c/8569/9/bin/rat_exclude_files=2Etxt@24 PS9, Line= 24: be/src/thirdparty/mpfit/* > The license part of the DISCLAIMER file ne= eds to be put in LICENSE=2Etxt in o Done http://gerrit=2Ecloudera=2Eorg:8= 080/#/c/8569/9/bin/run_clang_tidy=2Esh File bin/run_clang_tidy=2Esh: http:= //gerrit=2Ecloudera=2Eorg:8080/#/c/8569/9/bin/run_clang_tidy=2Esh@58 PS9, L= ine 58: # > I think this is leftovers=2E Sorry=2E Yes=2E -- To view, vi= sit http://gerrit=2Ecloudera=2Eorg:8080/8569 To unsubscribe, visit http://g= errit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Bra= nch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia51d56ee67ec6073= e92f90bebb4005484138b820 Gerrit-Change-Number: 8569 Gerrit-PatchSet: 9 Gerr= it-Owner: Alex Behm Gerrit-Reviewer: Alex Behm= Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerri= t-Reviewer: Jim Apple Gerrit-Comment-Date: Tu= e, 12 Dec 2017 17:54:37 +0000 Gerrit-HasComments: Yes --60a64I+tql8=--