Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 27D59200D57 for ; Mon, 11 Dec 2017 14:30:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 26759160C13; Mon, 11 Dec 2017 13:30:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6ADC7160C10 for ; Mon, 11 Dec 2017 14:30:06 +0100 (CET) Received: (qmail 70789 invoked by uid 500); 11 Dec 2017 13:30:05 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 70776 invoked by uid 99); 11 Dec 2017 13:30:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Dec 2017 13:30:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F0FB3C56AC for ; Mon, 11 Dec 2017 13:30:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kLsRxViSsw3q for ; Mon, 11 Dec 2017 13:30:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7AAA85F39F for ; Mon, 11 Dec 2017 13:30:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vBBDTx2F020295; Mon, 11 Dec 2017 13:29:59 GMT Message-Id: <201712111329.vBBDTx2F020295@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 6 Date: Mon, 11 Dec 2017 13:29:59 +0000 From: "Gabor Kaszab (Code Review)" To: Kim Jin Chul , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Attila Jeges X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5237=3A_Support_a_quoted_string_in_date/time_format=0A?= X-Gerrit-Change-Id: Ie34055ac695748bcfb110bfa6ed5308f469ea178 X-Gerrit-Change-Number: 8508 X-Gerrit-ChangeURL: X-Gerrit-Commit: d679377eaba8cf3f78f183ef4fefb5b61d3db733 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 11 Dec 2017 13:29:59 +0000 Reply-To: gaborkaszab@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, attilaj@cloudera.com, reviews@impala.incubator.apache.org, jinchul@gmail.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="aVXwU11eFmg="; charset=UTF-8 archived-at: Mon, 11 Dec 2017 13:30:07 -0000 --aVXwU11eFmg= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Gabor Kaszab has posted comments on this change=2E ( http://gerrit=2Ecloude= ra=2Eorg:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string = in date/time format =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 6: (2 comments) http://gerrit=2Ecloudera=2Eorg:8080/#/= c/8508/6/be/src/runtime/timestamp-parse-util=2Eh File be/src/runtime/timest= amp-parse-util=2Eh: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8508/6/be/src/= runtime/timestamp-parse-util=2Eh@190 PS6, Line 190: // nullptr if input = does not have unclosed quote > I see=2E Your point is that the pointer can = be changeable in the function=2E Wh My suggestion would be: "The expectatio= n for str is to point to the opening quote when the function is called=2E O= nce the function finishes str pointer is changed to point to the closing qu= ote=2E" http://gerrit=2Ecloudera=2Eorg:8080/#/c/8508/6/be/src/runtime/tim= estamp-parse-util=2Ecc File be/src/runtime/timestamp-parse-util=2Ecc: http= ://gerrit=2Ecloudera=2Eorg:8080/#/c/8508/6/be/src/runtime/timestamp-parse-u= til=2Ecc@178 PS6, Line 178: return quoted_string_begin + 1; > Do you thin= k the function name(i=2Ee=2E Get=2E=2E=2E) is still valid even though retu = Yes I do=2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8508 = To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-= Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerri= t-Change-Id: Ie34055ac695748bcfb110bfa6ed5308f469ea178 Gerrit-Change-Number= : 8508 Gerrit-PatchSet: 6 Gerrit-Owner: Kim Jin Chul = Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gab= or Kaszab Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Tim Armstrong = Gerrit-Comment-Date: Mon, 11 Dec 2017 13:29:59 +0000 Gerrit-HasComments: Ye= s --aVXwU11eFmg=--