Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201712111059.vBBAxkZO018758@ip-10-146-233-104.ec2.internal>
Date: Mon, 11 Dec 2017 10:59:46 +0000
From: "Kim Jin Chul (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Andre Araujo <araujo@cloudera.com>, John Russell <jrussell@cloudera.com>,
        Zoltan Borok-Nagy <boroknagyz@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2640=3A_Make_a_given_command_case-sensitive=0A?=
In-Reply-To: <gerrit.1512483633000.Ifdce9781d1d97596c188691b62a141b9bd137610@gerrit.cloudera.org>
References: <gerrit.1512483633000.Ifdce9781d1d97596c188691b62a141b9bd137610@gerrit.cloudera.org>
Reply-To: jinchul@gmail.com, jrussell@cloudera.com, impala-cr@cloudera.com,
        boroknagyz@cloudera.com, marcelk@gmail.com, araujo@cloudera.com,
        reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="BMsZtctZpZI="; charset=UTF-8
archived-at: Mon, 11 Dec 2017 10:59:52 -0000

--BMsZtctZpZI=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Kim Jin Chul has posted comments on this change=2E ( http://gerrit=2Ecloude=
ra=2Eorg:8080/8762 )

Change subject: IMPALA-2640: Make a given command cas=
e-sensitive
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E


=
Patch Set 7:

(2 comments)

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8762/7/=
tests/shell/test_shell_commandline=2Epy
File tests/shell/test_shell_command=
line=2Epy:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8762/7/tests/shell/test=
_shell_commandline=2Epy@585
PS7, Line 585:   def run_simple_command(self, c=
ommand):
             :     run_impala_shell_cmd('-q "%s;"' % command)
    =
         : 
             :   def test_commands(self):
             :     ""=
"Testing commands which have not been tested"""
             :     self=2Er=
un_simple_command("help")
> Why is this test added with this change?
These =
methods are unnecessary=2E They were introduced due to the code change for =
do_help at the patch set #5=2E See the line 1168 in 
https://gerrit=2Ecloud=
era=2Eorg/#/c/8762/5=2E=2E7/shell/impala_shell=2Epy


http://gerrit=2Ecloud=
era=2Eorg:8080/#/c/8762/7/tests/shell/test_shell_interactive=2Epy
File test=
s/shell/test_shell_interactive=2Epy:

http://gerrit=2Ecloudera=2Eorg:8080/#=
/c/8762/7/tests/shell/test_shell_interactive=2Epy@401
PS7, Line 401:       =
# IMPALA-5416: Test that a command following 'source' won't be run twice=2E=

             :       result =3D run_impala_shell_interactive(
            =
 :         "source shell_case_sensitive=2Ecmds;select \"second command\";")=

> The IMPALA-5416 part is a leftover from copy-pasting test_source_file=2E=
 "sel
Thanks for finding this=2E It's my mistake=2E Let me remove the inval=
id comment=2E


-- 
To view, visit http://gerrit=2Ecloudera=2Eorg:8080/876=
2
To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings

Gerri=
t-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Ger=
rit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610
Gerrit-Change-Numb=
er: 8762
Gerrit-PatchSet: 7
Gerrit-Owner: Kim Jin Chul <jinchul@gmail=2Ecom=
>
Gerrit-Reviewer: Andre Araujo <araujo@cloudera=2Ecom>
Gerrit-Reviewer: Jo=
hn Russell <jrussell@cloudera=2Ecom>
Gerrit-Reviewer: Kim Jin Chul <jinchul=
@gmail=2Ecom>
Gerrit-Reviewer: Zoltan Borok-Nagy <boroknagyz@cloudera=2Ecom=
>
Gerrit-Comment-Date: Mon, 11 Dec 2017 10:59:46 +0000
Gerrit-HasComments: =
Yes

--BMsZtctZpZI=--