Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B080A200D5E for ; Sat, 9 Dec 2017 01:08:21 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AF1F1160C1F; Sat, 9 Dec 2017 00:08:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 009BB160BFD for ; Sat, 9 Dec 2017 01:08:20 +0100 (CET) Received: (qmail 20582 invoked by uid 500); 9 Dec 2017 00:08:20 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 20571 invoked by uid 99); 9 Dec 2017 00:08:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Dec 2017 00:08:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 88ACD180791 for ; Sat, 9 Dec 2017 00:08:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id aZdyq1Vqy9EM for ; Sat, 9 Dec 2017 00:08:18 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id C084E5F470 for ; Sat, 9 Dec 2017 00:08:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vB908Fe5032363; Sat, 9 Dec 2017 00:08:15 GMT Message-Id: <201712090008.vB908Fe5032363@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Sat, 9 Dec 2017 00:08:15 +0000 From: "Tim Armstrong (Code Review)" To: Michael Ho , Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6291=3A_disable_AVX512_codegen_in_LLVM=0A?= X-Gerrit-Change-Id: Ic7c3ee3e370bafc50d855113485b7e6925f7bf6a X-Gerrit-Change-Number: 8802 X-Gerrit-ChangeURL: X-Gerrit-Commit: f52d6c5cba1f1b0e5b17f93e7ca316936b9d6c5f In-Reply-To: References: Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, kwho@cloudera.com, jbapple-impala@apache.org, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="Ts29tDXOHJc="; charset=UTF-8 archived-at: Sat, 09 Dec 2017 00:08:21 -0000 --Ts29tDXOHJc= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Michael Ho, Jim Apple, Impala Public Jenkins, I'd like you to reexa= mine a change=2E Please visit http://gerrit=2Ecloudera=2Eorg:8080/8802= to look at the new patch set (#4)=2E Change subject: IMPALA-6291: disabl= e AVX512 codegen in LLVM =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E IMPALA-6291: disable AVX512 codegen in LLVM Adds a whitelist= of LLVM CPU attributes that I know that we routinely test Impala with=2E T= his excludes the problematic AVX512 attributes as well as some other flags = we don't test with - e=2Eg=2E AMD-only instructions, NVM-related instructio= ns, etc=2E We're unlikely to get significant benefit from these instruction= set extensions without explicitly using them via instrinsics=2E Testing: = Ran core tests on a system with AVX512 support with a prototype patch that = disabled only the AVX512 flags=2E Added a backend test to make sure that th= e whitelisting is working as expected=2E Change-Id: Ic7c3ee3e370bafc50d855= 113485b7e6925f7bf6a --- M be/src/codegen/llvm-codegen-test=2Ecc M be/src/co= degen/llvm-codegen=2Ecc M be/src/codegen/llvm-codegen=2Eh 3 files changed, = 70 insertions(+), 2 deletions(-) git pull ssh://gerrit=2Ecloudera=2Eorg= :29418/Impala-ASF refs/changes/02/8802/4 -- To view, visit http://gerrit= =2Ecloudera=2Eorg:8080/8802 To unsubscribe, visit http://gerrit=2Ecloudera= =2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerr= it-MessageType: newpatchset Gerrit-Change-Id: Ic7c3ee3e370bafc50d855113485b= 7e6925f7bf6a Gerrit-Change-Number: 8802 Gerrit-PatchSet: 4 Gerrit-Owner: Ti= m Armstrong Gerrit-Reviewer: Impala Public Jenk= ins Gerrit-Reviewer: Jim Apple Gerrit-Reviewe= r: Michael Ho Gerrit-Reviewer: Tim Armstrong --Ts29tDXOHJc=--