Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201712071829.vB7ITxu8026531@ip-10-146-233-104.ec2.internal>
Date: Thu, 7 Dec 2017 18:29:59 +0000
From: "Impala Public Jenkins (Code Review)" <gerrit@cloudera.org>
To: Sailesh Mukil <sailesh@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4671=3A_=28part-2=29_Replace_kudu=3A=3AServicePool_with_one_that_uses_Impala_threads=0A?=
In-Reply-To: <gerrit.1509845229000.Ia3e0fa9ae22c4803b0cea736eb35e333e2671448@gerrit.cloudera.org>
References: <gerrit.1509845229000.Ia3e0fa9ae22c4803b0cea736eb35e333e2671448@gerrit.cloudera.org>
Reply-To: impala-cr@cloudera.com, sailesh@cloudera.com,
        reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="M+7A1z+2oAs="; charset=UTF-8
archived-at: Thu, 07 Dec 2017 18:30:18 -0000

--M+7A1z+2oAs=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Impala Public Jenkins has submitted this change and it was merged=2E ( http=
://gerrit=2Ecloudera=2Eorg:8080/8472 )

Change subject: IMPALA-4671: (part-=
2) Replace kudu::ServicePool with one that uses Impala threads
=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E

IMPALA-4671: (part-2) Rep=
lace kudu::ServicePool with one that uses Impala threads

The KuduRPC subsy=
stem uses kudu::ServicePool to service all incoming
RPCs=2E Since this live=
s inside the Kudu codebase, all instrumentation
of RPCs flowing through the=
 KuduRPC subsystem is not visible to Impala,
as Kudu does not export this i=
nstrumentation, but only maintains it
internally within kudu::ServicePool=
=2E

In order to reliably view the instrumentation of all RPCs flowing thro=
ugh
KRPC, one option is to modify kudu::ServicePool to take their
instrumen=
tation and display it on our webpages, which is very invasive=2E

A second =
option is to have a parallel implementation of kudu::ServicePool
which for =
all purposes behaves the same way, but instead has this extra
code that dis=
plays this instrumentation in our webpages=2E

This patch is Part 2 of the =
second option=2E

In Part 1, we simply copied the code from kudu::ServicePo=
ol into the Impala
namespace=2E In this patch, we rename the redundant kudu=
::ServicePool
(that was copied into be/src/rpc/) to ImpalaServicePool=2E We=
 also expose
the instrumentaion of the ImpalaServicePool as JSON=2E

Now, t=
he threads in use by the service pool will also be visible in
the /threadz =
page=2E

This patch however does not display instrumentation on the Webpage=
s yet=2E
In a future patch, we will add that through the ImpalaServicePool =
and the
RpcMgr=2E Tracked by IMPALA-6269

This patch is partially based on =
an abandoned patch by Henry Robinson=2E

Change-Id: Ia3e0fa9ae22c4803b0cea7=
36eb35e333e2671448
Reviewed-on: http://gerrit=2Ecloudera=2Eorg:8080/8472
Re=
viewed-by: Sailesh Mukil <sailesh@cloudera=2Ecom>
Tested-by: Impala Public =
Jenkins
---
M be/src/rpc/CMakeLists=2Etxt
M be/src/rpc/impala-service-pool=
=2Ecc
M be/src/rpc/impala-service-pool=2Eh
M be/src/rpc/rpc-mgr=2Ecc
M be/s=
rc/rpc/rpc-mgr=2Eh
M be/src/rpc/rpc-trace=2Eh
6 files changed, 119 insertio=
ns(+), 141 deletions(-)

Approvals:
  Sailesh Mukil: Looks good to me, appr=
oved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit=2E=
cloudera=2Eorg:8080/8472
To unsubscribe, visit http://gerrit=2Ecloudera=2Eo=
rg:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-M=
essageType: merged
Gerrit-Change-Id: Ia3e0fa9ae22c4803b0cea736eb35e333e2671=
448
Gerrit-Change-Number: 8472
Gerrit-PatchSet: 10
Gerrit-Owner: Sailesh Mu=
kil <sailesh@cloudera=2Ecom>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera=2E=
com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <l=
v@cloudera=2Ecom>
Gerrit-Reviewer: Michael Ho <kwho@cloudera=2Ecom>
Gerrit-=
Reviewer: Sailesh Mukil <sailesh@cloudera=2Ecom>

--M+7A1z+2oAs=--