Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 42FA4200D4E for ; Thu, 7 Dec 2017 11:18:19 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 416EB160C0C; Thu, 7 Dec 2017 10:18:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 860ED160BFE for ; Thu, 7 Dec 2017 11:18:18 +0100 (CET) Received: (qmail 97024 invoked by uid 500); 7 Dec 2017 10:18:17 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 97012 invoked by uid 99); 7 Dec 2017 10:18:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Dec 2017 10:18:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 26CD1C302B for ; Thu, 7 Dec 2017 10:18:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id evDAfDdbEABo for ; Thu, 7 Dec 2017 10:18:15 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B739D5F256 for ; Thu, 7 Dec 2017 10:18:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vB7AIDnk020435; Thu, 7 Dec 2017 10:18:14 GMT Message-Id: <201712071018.vB7AIDnk020435@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Thu, 7 Dec 2017 10:18:13 +0000 From: "Zoltan Borok-Nagy (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6242=3A_Reduce_flakiness_in_TimerCounterTest=0A?= X-Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412 X-Gerrit-Change-Number: 8670 X-Gerrit-ChangeURL: X-Gerrit-Commit: c1fd22b67e6249890f4fa179f312e3af17a01ad4 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 7 Dec 2017 10:18:13 +0000 Reply-To: boroknagyz@cloudera.com, impala-cr@cloudera.com, twang@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="WN1Bh4q0tII="; charset=UTF-8 archived-at: Thu, 07 Dec 2017 10:18:19 -0000 --WN1Bh4q0tII= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Zoltan Borok-Nagy has posted comments on this change=2E ( http://gerrit=2Ec= loudera=2Eorg:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in= TimerCounterTest =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E Patch Set 2: (2 comments) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8= 670/2/be/src/util/runtime-profile-test=2Ecc File be/src/util/runtime-profil= e-test=2Ecc: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8670/2/be/src/util/ru= ntime-profile-test=2Ecc@630 PS2, Line 630: if (csw_=2ETotalRunningTim= e() > 3000000000) { Might need to update this check as well=2E http://ger= rit=2Ecloudera=2Eorg:8080/#/c/8670/2/be/src/util/runtime-profile-test=2Ecc@= 631 PS2, Line 631: EXPECT_FALSE(false); It wasn't introduced in this commit= , but to my understanding EXPECT_FALSE(false) is a no-op, it doesn't fail t= he test=2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8670 T= o unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-P= roject: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit= -Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412 Gerrit-Change-Number:= 8670 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang G= errit-Reviewer: Tianyi Wang Gerrit-Reviewer: Zoltan = Borok-Nagy Gerrit-Comment-Date: Thu, 07 Dec 201= 7 10:18:13 +0000 Gerrit-HasComments: Yes --WN1Bh4q0tII=--