Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9A1F0200D63 for ; Thu, 7 Dec 2017 01:38:23 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 989EB160C1D; Thu, 7 Dec 2017 00:38:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E5380160C0A for ; Thu, 7 Dec 2017 01:38:22 +0100 (CET) Received: (qmail 67207 invoked by uid 500); 7 Dec 2017 00:38:22 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 67182 invoked by uid 99); 7 Dec 2017 00:38:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Dec 2017 00:38:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2564C18078F for ; Thu, 7 Dec 2017 00:38:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id s8rMz07snCj7 for ; Thu, 7 Dec 2017 00:38:19 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2FE865F47A for ; Thu, 7 Dec 2017 00:38:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vB70cGPe009978; Thu, 7 Dec 2017 00:38:16 GMT Message-Id: <201712070038.vB70cGPe009978@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 16 Date: Thu, 7 Dec 2017 00:38:16 +0000 From: "Kim Jin Chul (Code Review)" To: Michael Ho , Jim Apple , Attila Jeges , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5754=3A_Improve_randomness_of_rand=28=29/random=28=29=0A?= X-Gerrit-Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684 X-Gerrit-Change-Number: 8355 X-Gerrit-ChangeURL: X-Gerrit-Commit: 84e2a0cb0d363a83c072eb725cc2c03758022b83 In-Reply-To: References: Reply-To: jinchul@gmail.com, impala-cr@cloudera.com, marcelk@gmail.com, kwho@cloudera.com, jbapple-impala@apache.org, attilaj@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="avYinozsQ1Y="; charset=UTF-8 archived-at: Thu, 07 Dec 2017 00:38:23 -0000 --avYinozsQ1Y= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Michael Ho, Jim Apple, Attila Jeges, Impala Public Jenkins, I'd lik= e you to reexamine a change=2E Please visit http://gerrit=2Ecloudera= =2Eorg:8080/8355 to look at the new patch set (#16)=2E Change subject: IM= PALA-5754: Improve randomness of rand()/random() =2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E IMPALA-5754: Improve randomness of ra= nd()/random() Currently implementation of rand/random built-in functions u= se rand_r of C library=2E We recognized its randomness was poor=2E pcg32 of= third party library shows better randomness than rand_r=2E Testing: Revis= e unit test in expr-test Add E2E test to random=2Etest Change-Id: Idafdd5f= e7502ff242c76a91a815c565146108684 --- M LICENSE=2Etxt M be/src/exprs/expr-t= est=2Ecc M be/src/exprs/math-functions-ir=2Ecc A be/src/thirdparty/pcg-cpp-= 0=2E98/LICENSE=2Etxt A be/src/thirdparty/pcg-cpp-0=2E98/README=2Emd A be/sr= c/thirdparty/pcg-cpp-0=2E98/include/pcg_extras=2Ehpp A be/src/thirdparty/pc= g-cpp-0=2E98/include/pcg_random=2Ehpp A be/src/thirdparty/pcg-cpp-0=2E98/in= clude/pcg_uint128=2Ehpp M testdata/workloads/functional-query/queries/Query= Test/alloc-fail-init=2Etest A testdata/workloads/functional-query/queries/Q= ueryTest/random=2Etest M tests/query_test/test_queries=2Epy 11 files change= d, 3,454 insertions(+), 31 deletions(-) git pull ssh://gerrit=2Eclouder= a=2Eorg:29418/Impala-ASF refs/changes/55/8355/16 -- To view, visit http://= gerrit=2Ecloudera=2Eorg:8080/8355 To unsubscribe, visit http://gerrit=2Eclo= udera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master= Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idafdd5fe7502ff242c76a91= a815c565146108684 Gerrit-Change-Number: 8355 Gerrit-PatchSet: 16 Gerrit-Own= er: Kim Jin Chul Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: = Jim Apple Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Michael Ho --avYinozsQ1Y=--