Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201712061700.vB6H0g2o028463@ip-10-146-233-104.ec2.internal>
Date: Wed, 6 Dec 2017 17:00:42 +0000
From: "Laszlo Gaal (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>, Sailesh Mukil <sailesh@cloudera.com>,
        Jim Apple <jbapple-impala@apache.org>, Lars Volker <lv@cloudera.com>,
        Michael Brown <mikeb@cloudera.com>,
        Philip Zeyliger <philip@cloudera.com>,
        David Knupp <dknupp@cloudera.com>,
        Joe McDonnell <joemcdonnell@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>,
        Zach Amsden <zamsden@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6067=3A_Enable_S3_access_via_IAM_roles_for_EC2_VMs=0A?=
In-Reply-To: <gerrit.1508257187000.I14cd9d4453a91baad3c379aa7e4944993fca95ae@gerrit.cloudera.org>
References: <gerrit.1508257187000.I14cd9d4453a91baad3c379aa7e4944993fca95ae@gerrit.cloudera.org>
Reply-To: laszlo.gaal@cloudera.com, sailesh@cloudera.com, dknupp@cloudera.com,
        philip@cloudera.com, jbapple-impala@apache.org, alex.behm@cloudera.com,
        reviews@impala.incubator.apache.org, mikeb@cloudera.com,
        zamsden@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com,
        marcelk@gmail.com, tarmstrong@cloudera.com, joemcdonnell@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="gWEigNIX04Q="; charset=UTF-8
archived-at: Wed, 06 Dec 2017 17:00:48 -0000

--gWEigNIX04Q=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Laszlo Gaal has posted comments on this change=2E ( http://gerrit=2Eclouder=
a=2Eorg:8080/8294 )

Change subject: IMPALA-6067: Enable S3 access via IAM =
roles for EC2 VMs
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E


Patch Set 5:

(4 comments)

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8=
294/4/bin/check-s3-access=2Esh
File bin/check-s3-access=2Esh:

http://gerri=
t=2Ecloudera=2Eorg:8080/#/c/8294/4/bin/check-s3-access=2Esh@82
PS4, Line 82=
:   # an EC2 VM) or the IAM role cannot be retrieved=2E
> Please make this =
IP address a shell variable and set it above right after y
Done

Also added=
 a brief description of the instance metadata access mechanism and a link t=
o the relevant AWS doc page=2E


http://gerrit=2Ecloudera=2Eorg:8080/#/c/82=
94/4/bin/impala-config=2Esh
File bin/impala-config=2Esh:

http://gerrit=2Ec=
loudera=2Eorg:8080/#/c/8294/4/bin/impala-config=2Esh@345
PS4, Line 345: if =
(set +x; [[ -n ${AWS_SESSION_TOKEN-} ]]); then
> It's confusing that this i=
s backwards from line 334 and 324=2E i=2Ee=2E, in the f
Done


http://gerri=
t=2Ecloudera=2Eorg:8080/#/c/8294/4/bin/impala-config=2Esh@353
PS4, Line 353=
:     export DEFAULT_FS=3D"s3a://${S3_BUCKET}"
             :     export FI=
LESYSTEM
> nit:
Done


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8294/4/fe/sr=
c/test/java/org/apache/impala/analysis/AnalyzeStmtsTest=2Ejava
File fe/src/=
test/java/org/apache/impala/analysis/AnalyzeStmtsTest=2Ejava:

http://gerri=
t=2Ecloudera=2Eorg:8080/#/c/8294/4/fe/src/test/java/org/apache/impala/analy=
sis/AnalyzeStmtsTest=2Ejava@a3000
PS4, Line 3000: 
> If we believe this is =
tested in the e2e tests, I think it's fine to remove 
For the record: I end=
ed up removing it after running load=2Etest both for S3 and HDFS=2E


-- 
=
To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8294
To unsubscribe, vis=
it http://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF=

Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14cd9=
d4453a91baad3c379aa7e4944993fca95ae
Gerrit-Change-Number: 8294
Gerrit-Patch=
Set: 5
Gerrit-Owner: Laszlo Gaal <laszlo=2Egaal@cloudera=2Ecom>
Gerrit-Revi=
ewer: Alex Behm <alex=2Ebehm@cloudera=2Ecom>
Gerrit-Reviewer: David Knupp <=
dknupp@cloudera=2Ecom>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache=2E=
org>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera=2Ecom>
Gerrit-Re=
viewer: Lars Volker <lv@cloudera=2Ecom>
Gerrit-Reviewer: Laszlo Gaal <laszl=
o=2Egaal@cloudera=2Ecom>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera=2Ec=
om>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera=2Ecom>
Gerrit-Reviewe=
r: Sailesh Mukil <sailesh@cloudera=2Ecom>
Gerrit-Reviewer: Tim Armstrong <t=
armstrong@cloudera=2Ecom>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera=2E=
com>
Gerrit-Comment-Date: Wed, 06 Dec 2017 17:00:42 +0000
Gerrit-HasComment=
s: Yes

--gWEigNIX04Q=--