Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201712051946.vB5JkPrI003686@ip-10-146-233-104.ec2.internal>
Date: Tue, 5 Dec 2017 19:46:25 +0000
From: "Vuk Ercegovac (Code Review)" <gerrit@cloudera.org>
To: Philip Zeyliger <philip@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6273=3A_fixes_subquery_tests_for_functional_hbase=0A?=
In-Reply-To: <gerrit.1512498648000.Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0@gerrit.cloudera.org>
References: <gerrit.1512498648000.Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0@gerrit.cloudera.org>
Reply-To: vercegovac@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com,
        philip@cloudera.com, reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="peiUCsw5QK0="; charset=UTF-8
archived-at: Tue, 05 Dec 2017 19:46:30 -0000

--peiUCsw5QK0=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Philip Zeyliger, 

I'd like you to reexamine a change=2E Please visit=


    http://gerrit=2Ecloudera=2Eorg:8080/8765

to look at the new patch se=
t (#3)=2E

Change subject: IMPALA-6273: fixes subquery tests for functional=
_hbase
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E

IMPA=
LA-6273: fixes subquery tests for functional_hbase

IMPALA-1422 introduced =
tests that do not work with
the testing setup for hbase=2E Namely, tinyintt=
able is
not defined in the functional_hbase database, but
is defined in the=
 functional database=2E Exhaustive
tests uncovered the issue=2E

This chang=
e makes two changes so that tests work with
functional_hbase:
1) use a tabl=
e that is present in both functional and
   functional_hbase=2E the tests n=
eeded a subquery result
   with a single int column=2E tinyinttable is repl=
aced
   with an inline view that provides this single int
   column in a po=
rtable manner=2E
2) nulls are handled differently with hbase (see IMPALA-72=
8)
   so the nulltable used in the tests is set to
   functional=2Enulltabl=
e to avoid inconsistent results across
   input formats=2E

Testing:
- ran =
e2e tests with exhaustive exploration strategy for the
  broken test=2E

Ch=
ange-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0
---
M testdata/workloads=
/functional-query/queries/QueryTest/subquery-in-constant-lhs=2Etest
1 file =
changed, 13 insertions(+), 8 deletions(-)


  git pull ssh://gerrit=2Ecloud=
era=2Eorg:29418/Impala-ASF refs/changes/65/8765/3
-- 
To view, visit http:/=
/gerrit=2Ecloudera=2Eorg:8080/8765
To unsubscribe, visit http://gerrit=2Ecl=
oudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: maste=
r
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibaa3a3df7362ac6d3ed07a=
ff133dc4b3520bb4e0
Gerrit-Change-Number: 8765
Gerrit-PatchSet: 3
Gerrit-Own=
er: Vuk Ercegovac <vercegovac@cloudera=2Ecom>
Gerrit-Reviewer: Philip Zeyli=
ger <philip@cloudera=2Ecom>
Gerrit-Reviewer: Vuk Ercegovac <vercegovac@clou=
dera=2Ecom>

--peiUCsw5QK0=--