Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3BE34200D60 for ; Fri, 1 Dec 2017 20:58:28 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3A60C160C06; Fri, 1 Dec 2017 19:58:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 819A7160BF4 for ; Fri, 1 Dec 2017 20:58:27 +0100 (CET) Received: (qmail 78260 invoked by uid 500); 1 Dec 2017 19:58:26 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 78249 invoked by uid 99); 1 Dec 2017 19:58:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Dec 2017 19:58:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B21E018087C for ; Fri, 1 Dec 2017 19:58:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id xv5yIY59whXk for ; Fri, 1 Dec 2017 19:58:24 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id DD68D5FB5B for ; Fri, 1 Dec 2017 19:58:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id vB1JwMxe032578; Fri, 1 Dec 2017 19:58:22 GMT Message-Id: <201712011958.vB1JwMxe032578@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 8 Date: Fri, 1 Dec 2017 19:58:22 +0000 From: "Sailesh Mukil (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5053=3A_=5BSECURITY=5D_Make_KRPC_work_with_Kerberos=0A?= X-Gerrit-Change-Id: I8cec5cca5fdb4b1d46bab19e86cb1a8a3ad718fd X-Gerrit-Change-Number: 8270 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3dbd3464954a3fe1f81167476949e4783783421e In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 1 Dec 2017 19:58:22 +0000 Reply-To: sailesh@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, kwho@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="X6jeYMNMp8E="; charset=UTF-8 archived-at: Fri, 01 Dec 2017 19:58:28 -0000 --X6jeYMNMp8E= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sailesh Mukil has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC wo= rk with Kerberos =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E Patch Set 8: Code-Review+2 (2 comments) Carry +2 http://gerrit=2Ec= loudera=2Eorg:8080/#/c/8270/8/be/src/rpc/rpc-mgr=2Ecc File be/src/rpc/rpc-m= gr=2Ecc: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8270/8/be/src/rpc/rpc-mgr= =2Ecc@53 PS8, Line 53: // KuduRPC's flags : DECLARE_string(rpc_= authentication); > This can be removed now=2E Done http://gerrit=2Ecloude= ra=2Eorg:8080/#/c/8270/8/be/src/util/auth-util=2Ecc File be/src/util/auth-u= til=2Ecc: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8270/8/be/src/util/auth-= util=2Ecc@93 PS8, Line 93: split(names, names[1], is_any_of("@")); > Did yo= u double check if it's okay to use the same vector for both input and The d= ocumentation doesn't specify anything=2E So I just copied it to a new strin= g to be safe=2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8= 270 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Ger= rit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment G= errit-Change-Id: I8cec5cca5fdb4b1d46bab19e86cb1a8a3ad718fd Gerrit-Change-Nu= mber: 8270 Gerrit-PatchSet: 8 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: = Sailesh Mukil Gerrit-Comment-Date: Fri, 01 Dec 201= 7 19:58:22 +0000 Gerrit-HasComments: Yes --X6jeYMNMp8E=--