impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kim Jin Chul (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3942: Fix unexpected conversion of string literal in front-end
Date Tue, 12 Dec 2017 07:37:41 GMT
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8818


Change subject: IMPALA-3942: Fix unexpected conversion of string literal in front-end
......................................................................

IMPALA-3942: Fix unexpected conversion of string literal in front-end

Unexpected conversion from double quoted string literal to single quoted
string literal. A given string literal should be kept.

Testing:
Add some test cases to
TestStringLiteralBetweenDoubleQuotes.test_string_literal_between_double_quotes

Change-Id: Ibc4b5f5d8ffaa8feb96a466959427a04b3b06fec
---
M fe/src/main/java/org/apache/impala/analysis/StringLiteral.java
M fe/src/main/jflex/sql-scanner.flex
M tests/query_test/test_queries.py
3 files changed, 53 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/8818/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc4b5f5d8ffaa8feb96a466959427a04b3b06fec
Gerrit-Change-Number: 8818
Gerrit-PatchSet: 1
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message