impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6308: Fix bad Status() usage in data-stream-sender.cc
Date Tue, 12 Dec 2017 07:29:07 GMT
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8817


Change subject: IMPALA-6308: Fix bad Status() usage in data-stream-sender.cc
......................................................................

IMPALA-6308: Fix bad Status() usage in data-stream-sender.cc

Previously, DataStreamSender::FlushAndSendEos() makes some wrong
assumption about the format string of the error status returned
from DoTransmitDataRpc(). In particular, it assumes that the format
string has exactly one substitution argument. This is a pretty bad
assumption as new types of errors could be returned from
DoTransmitDataRpc() and they can take different numbers of
substitution arguments. Recent changes in the format string
TErrorCode::RPC_RECV_TIMEOUT exposed this bug.

This change fixes the problem by removing this bad usage of Status()
in data-stream-sender.cc

Change-Id: I1cc04db670069a7df484e2f2bafb93c5315b9c82
---
M be/src/runtime/data-stream-sender.cc
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/8817/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cc04db670069a7df484e2f2bafb93c5315b9c82
Gerrit-Change-Number: 8817
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kwho@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message