impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table
Date Mon, 11 Dec 2017 19:15:43 GMT
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8810


Change subject: IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table
......................................................................

IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table

Impala partitions and sorts rows according to the target table's
partitioning scheme before inserting them into Kudu in order to
improve the performance of large inserts.

A recent change added the ability to create unpartitioned Kudu tables,
but Impala still does the partitioning/sorting for them even though
its wasted work.

This patch modifies the planner to not add the partition/sort for Kudu
inserts if the table is unpartitioned.

Testing:
- Added a planner test for inserting into an unpartitioned Kudu table.
- Ran the existing correctness tests for inserts into unpartitioned
  Kudu tables in kudu_create.test

Change-Id: I3e01a7dd5284767a25df3218656746a5d0ee4632
---
M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test
3 files changed, 25 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/8810/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e01a7dd5284767a25df3218656746a5d0ee4632
Gerrit-Change-Number: 8810
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message