impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Gaal (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Prepare to move automated toolchain builds to a new environment
Date Thu, 07 Dec 2017 18:12:40 GMT
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8787


Change subject: Prepare to move automated toolchain builds to a new environment
......................................................................

Prepare to move automated toolchain builds to a new environment

This change updates the build scripts so that builds can take
advantage of preconfigured Amazon EC2 VM instances, where S3
credentials can be supplied by IAM roles instead of environment
variables.

Consequently, the credential checking logic before the S3 upload
is removed from functions.sh, where the binary artifacts are copied
to S3 using AWSCLI. AWSCLI will attempt to authenticate anyway,
and the script already has logic to decide whether an upload failure
should fail the whole build process, so there is no real value in
performing a similar check in the script at the same location.

There are also a couple of typos fixed in various comments.

Change-Id: I08d26206e33aa142b8c166aefe21ac1315fdbd3a
---
M functions.sh
M init-compiler.sh
M init.sh
3 files changed, 6 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/87/8787/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08d26206e33aa142b8c166aefe21ac1315fdbd3a
Gerrit-Change-Number: 8787
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <laszlo.gaal@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message