impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vuk Ercegovac (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3
Date Thu, 21 Dec 2017 20:42:42 GMT
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Alex Behm, 

I'd like you to reexamine a change. Please visit

to look at the new patch set (#2).

Change subject: IMPALA-3526: update FE tests to pass on S3

IMPALA-3526: update FE tests to pass on S3

Plans for some queries/same data may differ when
the same data is stored on S3 vs. HDFS. This is due
to block size differences used to enumerate range scans
on the different file systems. As a result, FE tests
have been disabled for S3 configurations. This has also
led to staleness in the tests that were specific to S3.
Most of the broken tests are due to staleness, but several
are due to true plan differences.

This change fixes stale tests and separates out those
test queries whose plans differ across S3 and HDFS.

- ran FE tests on S3

Change-Id: I4c8221949e76b0a0b9192e6b56c4da5eeae04141
M fe/src/test/java/org/apache/impala/planner/
M fe/src/test/java/org/apache/impala/planner/
A testdata/workloads/functional-planner/queries/PlannerTest/join-order-hdfs.test
A testdata/workloads/functional-planner/queries/PlannerTest/join-order-s3.test
M testdata/workloads/functional-planner/queries/PlannerTest/join-order.test
M testdata/workloads/functional-planner/queries/PlannerTest/s3.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpch-all-hdfs.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpch-all-s3.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-all.test
9 files changed, 2,171 insertions(+), 1,064 deletions(-)

  git pull ssh:// refs/changes/90/8890/2
To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4c8221949e76b0a0b9192e6b56c4da5eeae04141
Gerrit-Change-Number: 8890
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Vuk Ercegovac <>

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message