impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] KUDU-2228: Make Messenger options configurable
Date Thu, 21 Dec 2017 10:36:58 GMT
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 )

Change subject: KUDU-2228: Make Messenger options configurable
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

I manually compared this cherry pick with the original kudu change and made sure it compiles
on my dev machine.

http://gerrit.cloudera.org:8080/#/c/8878/2/be/src/kudu/util/flags.h
File be/src/kudu/util/flags.h:

http://gerrit.cloudera.org:8080/#/c/8878/2/be/src/kudu/util/flags.h@24
PS2, Line 24: #include "kudu/gutil/macros.h"
Is this necessary? I was able to build without it.



-- 
To view, visit http://gerrit.cloudera.org:8080/8878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
Gerrit-Change-Number: 8878
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburkert@apache.org>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Dec 2017 10:36:58 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message