impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5058: Improve the concurrency of DDL/DML operations
Date Fri, 15 Dec 2017 23:56:07 GMT
Alex Behm has posted comments on this change. ( )

Change subject: IMPALA-5058: Improve the concurrency of DDL/DML operations

Patch Set 2: Code-Review+1


I'm pretty happy with this change. I'm sure we can keep making improvements but I think it
would be good to get this change committed to let it bake. That should not stop us from considering
additional improvements to the structure/comments.

I encourage reviewers to keep posting improvement ideas.
File be/src/service/impala-server.h:
PS2, Line 339:   // Wait until the minimum catalog object version in the local cache exceeds
/// style

in the local cache is greater than or equal to 'min_catalog_update_version'
File common/thrift/StatestoreService.thrift:
PS1, Line 88:   // non-delta TTopicDelta's since the latest version of every still-present
topic item
> No, an optimization was added at some point to avoid sending deletions for 
So then should the second sentence start with "When true..."?
File fe/src/main/java/org/apache/impala/catalog/
PS2, Line 93:  * Periodically, the CatalogServiceCatalog collects a delta of catalog updates
(based on a
Thanks! This is really clear to me now.
PS2, Line 95:  * Each catalog topic update is defined by a range of catalog versions [from,
to) and the
(from, to]
PS2, Line 96:  * CatalogServiceCatalog guarantees that very catalog object that has a version
in the
typo: every

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If12467a83acaeca6a127491d89291dedba91a35a
Gerrit-Change-Number: 8752
Gerrit-PatchSet: 2
Gerrit-Owner: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <>
Gerrit-Comment-Date: Fri, 15 Dec 2017 23:56:07 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message