impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5310: Part 3: Use SAMPLED NDV() in COMPUTE STATS.
Date Fri, 15 Dec 2017 21:34:50 GMT
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8840
)

Change subject: IMPALA-5310: Part 3: Use SAMPLED_NDV() in COMPUTE STATS.
......................................................................


Patch Set 1: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8840/1/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java:

http://gerrit.cloudera.org:8080/#/c/8840/1/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@267
PS1, Line 267: SELECT COUNT(*) FROM tbl
Don't you need to have a TABLESAMPLE clause here and the round()... clause in the select list?


http://gerrit.cloudera.org:8080/#/c/8840/1/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@465
PS1, Line 465: Preconditions.checkState(effectiveSamplePerc_ <= 1.0);
nit: move it to L569 where this thing is populated.


http://gerrit.cloudera.org:8080/#/c/8840/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/8840/1/tests/common/impala_test_suite.py@628
PS1, Line 628: Sets the LOCATION of the 'dst_tbl' to be the same as 'src_tbl'.
             :     If 'recover_partitions' is True, also runs ALTER TABLE RECOVER PARTITIONS
             :     on the cloned table."""
remove, you're just describing the code below :)



-- 
To view, visit http://gerrit.cloudera.org:8080/8840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ec0831f77698695975e45ec0bc0364c765d819b
Gerrit-Change-Number: 8840
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Dec 2017 21:34:50 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message