impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.
Date Fri, 15 Dec 2017 17:30:07 GMT
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784
)

Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8784/4/tests/common/impala_service.py
File tests/common/impala_service.py:

http://gerrit.cloudera.org:8080/#/c/8784/4/tests/common/impala_service.py@81
PS4, Line 81:         return None
> Umm...I should have been clearer on this. It's the Impala server returning 
Ok, that makes sense.

So, could we:

a) Assert that the HTTP request returns a non-200 response. (If it returns a 200 OK, that's
a bug, which we can file.)

b) Assert that "Could not obtain runtime profile" is in the output

This way, if Impala ever returns invalid Thrift, we won't accidentally swallow it.



-- 
To view, visit http://gerrit.cloudera.org:8080/8784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3421a34cc029ebca551730084c7cbd402d5c109
Gerrit-Change-Number: 8784
Gerrit-PatchSet: 5
Gerrit-Owner: Zoram Thanga <zoram@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zoram@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Dec 2017 17:30:07 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message