impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()
Date Wed, 13 Dec 2017 06:24:44 GMT
Jim Apple has posted comments on this change. ( )

Change subject: IMPALA-5754: Improve randomness of rand()/random()

Patch Set 21: Code-Review+2

> Thanks for the information. I would like to exclude the third party
 > library because the modification of the library seems not to be
 > maintainable and delivery of the modification to the upstream might
 > not be acceptable. When I checked the logs, there are trivial
 > issues only:
 > - warning: 'PCG_USE_ZEROCHECK_ROTATE_IDIOM' is not defined,
 > evaluates to 0
 > - warning: expansion of date or time macro is not reproducible

I'm not 100% sure I agree with you there, but let's consider tackling that in a later patch.

You'll notice that be/src/thirdparty/squeasel and mustache are sometimes modified independent
of their source, and one of the warnings about reproducability can prevent support nightmares.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684
Gerrit-Change-Number: 8355
Gerrit-PatchSet: 21
Gerrit-Owner: Kim Jin Chul <>
Gerrit-Reviewer: Attila Jeges <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Kim Jin Chul <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Comment-Date: Wed, 13 Dec 2017 06:24:44 +0000
Gerrit-HasComments: No

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message