impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence
Date Wed, 13 Dec 2017 00:10:53 GMT
Hello Michael Ho, Joe McDonnell, Dan Hecht, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8758

to look at the new patch set (#5).

Change subject: IMPALA-6190/6246: Add instances tab and event sequence
......................................................................

IMPALA-6190/6246: Add instances tab and event sequence

This change adds tracking of the current state during the execution of a
fragment instance. The current state is then reported back to the
coordinator and exposed to users via a new tab in the query detail debug
webpage.

This change also adds an event timeline to fragment instances in the
query profile. The timeline measures the time since fragment start at
which particular events complete. Events are derived from the current
state of the execution of a fragment instance. For example:

    - Codegen Finished: 79.312ms (79.312ms)
    - Prepare Finished: 79.454ms (141.949us)
    - Open Finished: 93.287ms (13.832ms)
    - First Batch Received: 259.751ms (166.464ms)
    - First Batch Sent: 260.219ms (467.917us)
    - ExecInternal Finished: 2s733ms (2s473ms)

I added automated tests for both extensions and additionally verified
the change by manual inspection.

Change-Id: I626456b6afa9101eeeeffd5cda10c4096d63d7f9
---
M be/src/common/atomic.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/query-state.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile.cc
M common/thrift/ImpalaInternalService.thrift
M tests/query_test/test_observability.py
M tests/webserver/test_web_pages.py
M www/query_detail_tabs.tmpl
A www/query_finstances.tmpl
17 files changed, 535 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/8758/5
-- 
To view, visit http://gerrit.cloudera.org:8080/8758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I626456b6afa9101eeeeffd5cda10c4096d63d7f9
Gerrit-Change-Number: 8758
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message