impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker
Date Tue, 12 Dec 2017 18:38:21 GMT
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8782 )

Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8782/3/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

http://gerrit.cloudera.org:8080/#/c/8782/3/be/src/runtime/exec-env.cc@353
PS3, Line 353:  MemTracker(tcmalloc_overhead
The assumption is that 'tcmalloc_overhead' is not used in the destructor of MemTracker so
it shouldn't be affected by the order in which the objects are destroyed in the object pool.



-- 
To view, visit http://gerrit.cloudera.org:8080/8782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I602e9d5e8e8d7470dcfe4addde3265057c16263a
Gerrit-Change-Number: 8782
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Dec 2017 18:38:21 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message